New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't remove "new" and "const" from dartfmt itself yet. #701

Merged
merged 1 commit into from Jun 18, 2018

Conversation

Projects
None yet
3 participants
@munificent
Member

munificent commented Jun 18, 2018

Reverts d80a1ea.

Since people import dartfmt as a library, I don't want to require them
to move to Dart 2 just yet, so I'm going to postpone removing "new" and
"const" from dartfmt itself for a while.

It, of course, still supports "--fix" and is able to remove them from
your code.

Don't remove "new" and "const" from dartfmt itself yet.
Reverts d80a1ea.

Since people import dartfmt as a library, I don't want to require them
to move to Dart 2 just yet, so I'm going to postpone removing "new" and
"const" from dartfmt itself for a while.

It, of course, still supports "--fix" and is able to remove them from
*your* code.

@munificent munificent requested a review from kevmoo Jun 18, 2018

@googlebot googlebot added the cla: yes label Jun 18, 2018

@kevmoo

kevmoo approved these changes Jun 18, 2018

@munificent munificent merged commit 8d6511e into master Jun 18, 2018

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@munificent munificent deleted the revert-dogfood branch Jun 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment