New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests for doc comment fix and fix an edge case. #741

Merged
merged 1 commit into from Sep 17, 2018

Conversation

Projects
None yet
3 participants
@munificent
Member

munificent commented Sep 17, 2018

A line that didn't have a leading * but did have a * elsewhere in
the line would have everything before the * trimmed.

cc @lrhn

Add more tests for doc comment fix and fix an edge case.
A line that didn't have a leading "*" but did have a "*" elsewhere in
the line would have everything before the "*" trimmed.

@munificent munificent requested a review from natebosch Sep 17, 2018

@googlebot googlebot added the cla: yes label Sep 17, 2018

munificent referenced this pull request Sep 17, 2018

Revise doc comment fix (#735)
* add fix for doc comments

* Revise "--fix-doc-comments".

- Treat "**/" as a valid end comment and remove both "**".
- Don't treat "/****", etc. as a doc comment. Preserves some cases where
  users use that for boxes.
- Don't strip the first character in lines that don't have a "*".
- Add some more tests.
- Bump the version and update the CHANGELOG.

* Revise.
/// Example:
/// ```dart
/// /** Doc comment */
/// var grumshack = getGrumshack();

This comment has been minimized.

@natebosch

natebosch Sep 17, 2018

Member

@munificent munificent merged commit 011ac71 into master Sep 17, 2018

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@munificent munificent deleted the fix-doc-comment-fix branch Sep 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment