Eliminate dartdoc-global cache of ModelElements/Analyzer bits #1800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devoncarew
approved these changes
Oct 15, 2018
There was a problem hiding this comment.
Do you want to reset the parallelization change (#1797) here or wait for a follow-up?
|
I think I'd prefer do that in a followup. |
pq
approved these changes
Oct 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1799.
Not really sure how the tests managed to pass with this not done. Not impacting regular use of dartdoc, there was a global cache of dart objects in markdown_processor.dart that wasn't getting cleared between runs in the test. Move that to PackageGraph so it lives and dies with the instance, as it should.
After this, I can no longer reproduce #1799.