Skip to content

Connect interface types across private intermediate classes #2495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 29, 2021

Conversation

jcollins-g
Copy link
Contributor

This addresses most of #2485 by connecting implemented types across intermediate private classes. Type parameters, however, are not translated in this PR and will need a followup, but I think this is an improvement.

@google-cla google-cla bot added the cla: yes Google CLA check succeeded. label Jan 28, 2021
@jcollins-g jcollins-g requested a review from srawlins January 28, 2021 23:50
Copy link
Member

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

w00t!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.638% when pulling 0087684 on jcollins-g:implements-fail-1623 into 619a128 on dart-lang:master.

@jcollins-g jcollins-g merged commit 30b4df2 into dart-lang:master Jan 29, 2021
@jcollins-g jcollins-g deleted the implements-fail-1623 branch January 29, 2021 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants