Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor category renderer cleanup #2537

Merged
merged 2 commits into from
Feb 25, 2021
Merged

Minor category renderer cleanup #2537

merged 2 commits into from
Feb 25, 2021

Conversation

parlough
Copy link
Member

@parlough parlough commented Feb 24, 2021 •
edited
Loading

Cleans up the category renderer a bit:

  • Adds some very basic dartdocs
  • Switches to const constructors
  • Switch rendering HTML to use StringBuffer throughout as we already used it for part. Some minor perf benefits here since this logic is hit more often.

@google-cla google-cla bot added the cla: yes Google CLA check succeeded. label Feb 24, 2021
@coveralls
Copy link

coveralls commented Feb 24, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.001%) to 91.627% when pulling 656abf4 on parlough:misc/category-renderer-cleanup into d22e3df on dart-lang:master.

@parlough
Copy link
Member Author

parlough commented Feb 24, 2021 •
edited
Loading

The macOS test has been intermittently failing due to timeouts, if you resubmit the checks it should be fine.

@jcollins-g jcollins-g merged commit 7645ef8 into dart-lang:master Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcollins-g jcollins-g jcollins-g approved these changes

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parlough @coveralls @jcollins-g