Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid json on an empty categories list #2550

Merged
merged 1 commit into from Mar 1, 2021
Merged

Fix invalid json on an empty categories list #2550

merged 1 commit into from Mar 1, 2021

Conversation

jcollins-g
Copy link
Contributor

Fix a bug introduced in #2534 that's blocking a downstream roll. After that PR if there are no categories defined, dartdoc will write only \n which is not valid JSON.

@google-cla google-cla bot added the cla: yes Google CLA check succeeded. label Mar 1, 2021
@jcollins-g jcollins-g requested a review from srawlins March 1, 2021 18:46
parlough
parlough approved these changes Mar 1, 2021
View reviewed changes
Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I didn't think of that, this looks good, thanks!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.741% when pulling d8ec7cc on jcollins-g:invalid-json-empty-categories into f8d62e0 on dart-lang:master.

@jcollins-g jcollins-g merged commit fbb3664 into dart-lang:master Mar 1, 2021
@jcollins-g jcollins-g deleted the invalid-json-empty-categories branch March 1, 2021 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srawlins srawlins srawlins approved these changes

@parlough parlough parlough approved these changes

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jcollins-g @coveralls @srawlins @parlough