Skip to content

Conversation

@mosuem
Copy link
Member

@mosuem mosuem commented Aug 25, 2023

An attempt to fix the exception in https://github.com/dart-lang/i18n/actions/runs/5802196156/job/16215135674, and also good in general to use the "official" API.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@github-actions
Copy link

github-actions bot commented Aug 25, 2023

PR Health

Package publish validation ✔️

Details
Package Version Status
package:firehose 0.3.25 ready to publish
package:dart_flutter_team_lints 1.0.0 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

License Headers ✔️

Details
// Copyright (c) 2023, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Changelog Entry ✔️

Details
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️

Details
File Coverage
pkgs/firehose/lib/src/pub.dart 💚 100 %

This check for test coverage is informational (issues shown here will not fail the PR).

@github-actions
Copy link

Package publishing

Package Version Status Publish tag (post-merge)
package:firehose 0.3.25 ready to publish firehose-v0.3.25
package:dart_flutter_team_lints 1.0.0 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@mosuem mosuem requested a review from devoncarew August 25, 2023 14:35
@mosuem mosuem merged commit 65817bf into main Aug 29, 2023
@mosuem mosuem deleted the switchToApi branch August 29, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants