docs(http): add http.client Testing section with Flutter testing cookbook recommendation #1836

arowolojoshuao · 2025-10-19T08:14:29Z

Summary

Adds a Testing section to the README that addresses the Flutter testing cookbook recommendation to use http.Client instances instead of static methods for better testability.

Changes

Added Testing section after the composable client examples
Included dependency injection pattern example with DataService class
Added MockClient testing example with complete test case
Referenced Flutter testing cookbook for best practices

Related Issue

Fixes #389

Testing

Verified documentation formatting renders correctly
Ensured code examples are syntactically correct
Confirmed links to Flutter testing cookbook are valid

…ndation

github-actions · 2025-10-28T00:14:36Z

PR Health

Changelog Entry ✔️

Package	Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

Coverage ✔️

File	Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

License Headers ✔️

// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers

Files
pkgs/http/example/main.dart

This check can be disabled by tagging the PR with skip-license-check.

brianquinlan

Awesome! Thank you for this!

brianquinlan · 2025-10-28T00:18:28Z

pkgs/http/README.md


+## Testing
+
+For better testability, especially in Flutter applications, it's recommended to use a [Client][] instance rather than the top-level functions like `http.get()` or `http.post()`. This approach makes it easier to mock HTTP requests in your tests.


Could you wrap the lines to 80 columns?

brianquinlan · 2025-10-28T00:23:01Z

pkgs/http/README.md

+```
+
+> [!TIP]
+> For more detailed testing guidance, see the


Maybe use more neutral language about mockito:

You can also use package:mockito to mock `http.Client.

For more detailed guidance, see the Flutter Testing Cookbook.

brianquinlan · 2025-10-28T00:24:58Z

pkgs/http/README.md


 Some well-supported implementations are:

-| Implementation | Supported Platforms | SDK | Caching | HTTP3/QUIC | Platform Native | 


Could you restore the original formatting? It's hard to read this in a narrow window.

brianquinlan · 2025-10-28T00:25:07Z

pkgs/http/README.md


-> [!TIP]
-> [The Flutter HTTP example application][flutterhttpexample] demonstrates
+> [!TIP] > [The Flutter HTTP example application][flutterhttpexample] demonstrates


Please restore this.

brianquinlan · 2025-10-28T00:25:11Z

pkgs/http/README.md


-> [!TIP]
-> [The Flutter HTTP example application][flutterhttpexample] demonstrates
+> [!TIP] > [The Flutter HTTP example application][flutterhttpexample] demonstrates


Please restore this.

arowolojoshuao · 2025-10-28T08:15:56Z

@brianquinlan, thank you for reviewing the PR. I have addressed your comments and pushed the updates.
Please take a look when you have a moment. Thanks

arowolojoshuao · 2025-10-29T08:28:47Z

@brianquinlan, I have addressed the failing health check

brianquinlan

Thank you for writing this!

arowolojoshuao added 2 commits October 19, 2025 09:03

docs(http): add Testing section with Flutter testing cookbook recomme…

c4cec9d

…ndation

docs(http): formatted tables

a7aa3c9

github-actions bot added the package:http label Oct 19, 2025

brianquinlan requested changes Oct 28, 2025

View reviewed changes

docs(http): restored and cleanup the files

5dc1417

arowolojoshuao requested a review from brianquinlan October 28, 2025 08:16

docs(http): Updated changelog.md to include the changes

9d0e229

brianquinlan added 2 commits November 3, 2025 11:13

Clarify what this change does.

9bf9472

Update README.md

9d5ad4d

brianquinlan approved these changes Nov 3, 2025

View reviewed changes

brianquinlan merged commit 81b5979 into dart-lang:master Nov 3, 2025
34 of 36 checks passed


		## Testing

		For better testability, especially in Flutter applications, it's recommended to use a [Client][] instance rather than the top-level functions like `http.get()` or `http.post()`. This approach makes it easier to mock HTTP requests in your tests.


		Some well-supported implementations are:

		\| Implementation \| Supported Platforms \| SDK \| Caching \| HTTP3/QUIC \| Platform Native \|

docs(http): add http.client Testing section with Flutter testing cookbook recommendation #1836

docs(http): add http.client Testing section with Flutter testing cookbook recommendation #1836

Uh oh!

Conversation

arowolojoshuao commented Oct 19, 2025

Summary

Changes

Related Issue

Testing

Uh oh!

github-actions bot commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Health

Uh oh!

brianquinlan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

arowolojoshuao commented Oct 28, 2025

Uh oh!

arowolojoshuao commented Oct 29, 2025

Uh oh!

brianquinlan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Oct 28, 2025 •

edited

Loading