Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NumberFormat documentation is referring to non-existent decimalFormat, percentFormat, etc #204

Closed
apaatsio opened this issue Mar 4, 2019 · 1 comment
Closed

NumberFormat documentation is referring to non-existent decimalFormat, percentFormat, etc #204

apaatsio opened this issue Mar 4, 2019 · 1 comment

Comments

@apaatsio
Copy link

apaatsio commented Mar 4, 2019

The documentation mentions decimalFormat, percentFormat, scientificFormat, and currencyFormat, none of which exist. I suppose these should be decimalPattern, percentPattern, scientificPattern, and currency, respectively.

https://github.com/dart-lang/intl/blob/5e0817412a746f5329d18ff3eba9c2b46104f935/lib/src/intl/number_format.dart#L36-L45
@apaatsio apaatsio changed the title Documentation is referring to non-existent decimalFormat, percentFormat, etc NumberFormat documentation is referring to non-existent decimalFormat, percentFormat, etc Mar 4, 2019
@alan-knight
Copy link
Contributor

Thanks. There are also several more constructors than when that was written. Update pending.

alan-knight referenced this issue in dart-archive/intl Jan 6, 2020
@alan-knight
Fix obsolete documentation
2fcf1e0 
https://github.com/dart-lang/intl/issues/202

PiperOrigin-RevId: 280266302
mosuem referenced this issue Mar 2, 2023
@alan-knight
Fix obsolete documentation
b0ffb89 
https://github.com/dart-lang/intl/issues/202

PiperOrigin-RevId: 280266302
@mosuem mosuem transferred this issue from dart-archive/intl Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@apaatsio @alan-knight