From e783cb4d87f585a7a52105019ed34e6a351b44bb Mon Sep 17 00:00:00 2001 From: Brian Quinlan Date: Thu, 18 Sep 2025 21:14:32 -0700 Subject: [PATCH 1/3] Add sign conversion --- pkgs/unix_api/hook/build.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/unix_api/hook/build.dart b/pkgs/unix_api/hook/build.dart index 534cdba3..ea0335b3 100644 --- a/pkgs/unix_api/hook/build.dart +++ b/pkgs/unix_api/hook/build.dart @@ -15,7 +15,7 @@ void main(List args) async { name: packageName, assetName: 'libc_shim', sources: ['src/libc_shim.c', 'src/constants.g.c'], - flags: ['-Weverything'], + flags: ['-Weverything', '-Wsign-conversion'], ).run( input: input, output: output, From b2869a0742d431831a8ff02f918859b2705b51fc Mon Sep 17 00:00:00 2001 From: Brian Quinlan Date: Thu, 18 Sep 2025 21:16:28 -0700 Subject: [PATCH 2/3] Update unix_api.yml --- .github/workflows/unix_api.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/unix_api.yml b/.github/workflows/unix_api.yml index 970e5213..a0cc7f6b 100644 --- a/.github/workflows/unix_api.yml +++ b/.github/workflows/unix_api.yml @@ -47,7 +47,7 @@ jobs: with: sdk: dev - run: dart pub get - - run: dart --enable-experiment=native-assets run tool/generate.dart + - run: dart run tool/generate.dart - run: git diff --exit-code desktop-vm-test: @@ -62,4 +62,4 @@ jobs: - uses: dart-lang/setup-dart@e51d8e571e22473a2ddebf0ef8a2123f0ab2c02c with: sdk: ${{ matrix.sdk }} - - run: dart --enable-experiment=native-assets test --reporter=failures-only --test-randomize-ordering-seed=random --platform vm + - run: dart test --reporter=failures-only --test-randomize-ordering-seed=random --platform vm From 888c4580b71224cfc695e4948076bd1c6134eca7 Mon Sep 17 00:00:00 2001 From: Brian Quinlan Date: Thu, 18 Sep 2025 21:18:19 -0700 Subject: [PATCH 3/3] Update build.dart --- pkgs/unix_api/hook/build.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/unix_api/hook/build.dart b/pkgs/unix_api/hook/build.dart index ea0335b3..534cdba3 100644 --- a/pkgs/unix_api/hook/build.dart +++ b/pkgs/unix_api/hook/build.dart @@ -15,7 +15,7 @@ void main(List args) async { name: packageName, assetName: 'libc_shim', sources: ['src/libc_shim.c', 'src/constants.g.c'], - flags: ['-Weverything', '-Wsign-conversion'], + flags: ['-Weverything'], ).run( input: input, output: output,