Broadened to skip all operators.

dart-lang · Oct 24, 2017 · 3ead7be · 3ead7be
1 parent 20e2e9c
commit 3ead7be
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/lib/src/rules/avoid_positional_boolean_parameters.dart b/lib/src/rules/avoid_positional_boolean_parameters.dart
@@ -36,9 +36,6 @@ new Button(ButtonState.enabled);
 bool _hasInheritedMethod(MethodDeclaration node) =>
     DartTypeUtilities.lookUpInheritedMethod(node) != null;
 
-bool _indexEqOp(MethodDeclaration node) =>
-    node.isOperator && node.name.token.type == TokenType.INDEX_EQ;
-
 bool _isNamedParameter(FormalParameter node) =>
     node.kind == ParameterKind.NAMED;
 
@@ -88,7 +85,7 @@ class _Visitor extends SimpleAstVisitor {
   visitMethodDeclaration(MethodDeclaration node) {
     if (!node.isSetter &&
         !node.element.isPrivate &&
-        !_indexEqOp(node) &&
+        !node.isOperator &&
         !_hasInheritedMethod(node)) {
       final parametersToLint =
           node.parameters?.parameters?.where(_isFormalParameterToLint);

diff --git a/test/rules/avoid_positional_boolean_parameters.dart b/test/rules/avoid_positional_boolean_parameters.dart
@@ -50,6 +50,11 @@ class C {
   void operator []=(int index, bool value) { // OK (#803)
   }
 
+  void operator +(bool value) { // OK (#803)
+  }
+
+  void operator -(bool value) { // OK (#803)
+  }
 }
 
 class D {