Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use `prefer_double_quotes` with dartanalyzer 2.3.2 #1607

Closed
passsy opened this issue Jun 12, 2019 · 4 comments

Comments

Projects
None yet
4 participants
@passsy
Copy link

commented Jun 12, 2019

When I add prefer_double_quotes to my project (dart sdk 2.3.2) I get the warning 'prefer_double_quotes' is not a recognized lint rule.
Running dartanalyzer (version 2.3.2) also doesn't seem to support the new rule.

What do I have to update, so that dartanalyzer is using the latest linter version?

analyzer hasn't been updated since the new prefer_double_quotes was added. Is that the missing part?

@bwilkerson

This comment has been minimized.

Copy link
Member

commented Jun 12, 2019

That would certainly explain it, yes. The lint rules are not dynamically loaded, they are statically compiled into the analyzer and analysis server snapshots, so changes to the linter package do not reach users until (a) the latest linter package has been vended into the SDK and (b) a new version of the SDK has been released.

@bwilkerson bwilkerson closed this Jun 12, 2019

@Stargator

This comment has been minimized.

Copy link

commented Jun 12, 2019

@bwilkerson 2.3.3 looks to be released on 6/24/2019. But no mention of prefer_double_quotes, do you know if that is an oversight or if the lint will be released after 2.3.3?

@bwilkerson

This comment has been minimized.

Copy link
Member

commented Jun 12, 2019

No, I don't know. But I just saw #1609, which might suggest that there is an issue with the rule that is preventing it from being recognized.

@pq

This comment has been minimized.

Copy link
Member

commented Jun 14, 2019

Sorry for the confusion. That lint was introduced to the SDK in 2.3.2-dev.0.0. It looks like the changelog for 2.3.3 wasn't correctly updated though it should be available there.

cc @aadilmaan (fyi and a placeholder for a conversation about managing the changelist)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.