Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

☂️ [task] remove DartProject #3395

Closed
6 of 10 tasks
pq opened this issue May 12, 2022 · 1 comment
Closed
6 of 10 tasks

☂️ [task] remove DartProject #3395

pq opened this issue May 12, 2022 · 1 comment
Assignees
@pq
Labels
meta type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable type-task

Comments

@pq
Copy link
Member

pq commented May 12, 2022 •
edited

DartProject has never worked completely w/ server (see #154) and since it's creation, LinterContext has been introduced which, moving forward, is the right way to answer the kinds of questions it was designed to address. Since the lints that are currently using it are failing fast, my thinking is that we can safely remove all references to it from the existing lints as a non-breaking change. We can then follow-up with a new set of changes that updates the (already) broken lints to use LinterContext methods. These changes will produce a bunch of new diagnostics which though (now) correct may have ecosystem impact so we'll want to carefully vet their roll-out.

Plan
@pq pq added type-task type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable meta labels May 12, 2022
@pq pq self-assigned this May 12, 2022
This was referenced May 12, 2022
Merged
Merged
Merged
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue May 16, 2022
@pq
deprecate DartProject
aa616d6 
See: dart-lang/linter#3395

Change-Id: Id0d342d4a15676acbe5bdd26b245b1325764922f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/244760
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
@pq pq mentioned this issue May 18, 2022
Closed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue May 19, 2022
@pq
remove DartProject
48ff7ca 
See: dart-lang/linter#3395

Change-Id: I6e4213983abae2b48e4bbbbbc766784e1756b0ed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245240
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
@pq
Copy link
Member Author

pq commented Nov 14, 2022

This is at a natural stopping point. If the functionality additions get picked up, they can get tracked in their own issues.

@pq pq closed this as completed Nov 14, 2022
@parlough parlough mentioned this issue Feb 7, 2024
Closed
@pq pq mentioned this issue Apr 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pq pq

Labels
meta type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable type-task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pq