Expect unawaited futures in test.expect (attempt to fix #419) #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expect(fut(), throws); // Ok!
ochafik
force-pushed
the
expect_unawaited_futures
branch
from
bb52d0f
to
9d80b45
Compare
bwilkerson
approved these changes
Feb 19, 2017
|
An alternative would be #419 (comment) to allow APIs themselves to opt out instead of special-casing in the linter rule. |
pq
reviewed
Feb 19, 2017
| if (libUri == null) return false; | ||
|
|
||
| return libUri.startsWith('package:test/') || | ||
| libUri.startsWith('package:unittest/'); |
There was a problem hiding this comment.
(not that it matters anymore, but fyi most our tests are still using unittest :-))
kevmoo
requested changes
Feb 19, 2017
|
@kevmoo : is that conversation on an issue somewhere? If not, could you post status somewhere we can follow? |
|
Thanks @kevmoo . I think as of dart-lang/test#546, this becomes moot and @ochafik you can safely close this? |
|
Cool, closing this, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I couldn't find an easy way to test the package origin from the tests themselves, suggestions welcome! Also, not sure if that will work with summaries (do we still have sourcefiles then?), etc... Pointers as to how to test would be welcome!