Skip to content

Add ignore_for_file: camel_case_types to generated file #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2021
Merged

Add ignore_for_file: camel_case_types to generated file #471

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/src/builder.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,9 @@ class MockBuilder implements Builder {
'// ignore_for_file: invalid_use_of_visible_for_testing_member\n'));
b.body.add(Code('// ignore_for_file: prefer_const_constructors\n'));
// The code_builder `asA` API unconditionally adds defensive parentheses.
b.body.add(Code('// ignore_for_file: unnecessary_parenthesis\n\n'));
b.body.add(Code('// ignore_for_file: unnecessary_parenthesis\n'));
Copy link
Member

@kevmoo kevmoo Sep 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An aside for @srawlins – wonder if we should pull these ignores into a constant and DRY up this logic a bit...

Copy link
Member

@srawlins srawlins Sep 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do like having a comment for why each one might be needed.

Copy link
Member

@kevmoo kevmoo Sep 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That could go in the constant definition, right?

Copy link
Member

@srawlins srawlins Sep 8, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it could.

I do hope to eliminate all of these and replace with dart-lang/sdk#46957.

Copy link
Contributor Author

@RTodorov RTodorov Sep 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the meantime, could we perhaps get this one merged? :)

Copy link
Member

@srawlins srawlins Sep 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the support just landed for "all lints", but it will be introduced in Dart 2.15, which is many moons from now.

// The generator appends a suffix to fake classes
b.body.add(Code('// ignore_for_file: camel_case_types\n\n'));
b.body.addAll(mockLibraryInfo.fakeClasses);
b.body.addAll(mockLibraryInfo.mockClasses);
});
Expand Down