-
Notifications
You must be signed in to change notification settings - Fork 82
[ffigen] Add more Objective-C documentation #2707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR HealthBreaking changes ✔️
This check can be disabled by tagging the PR with Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
This check can be disabled by tagging the PR with License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
This check can be disabled by tagging the PR with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two overall comments:
- maybe add a
docs/README.mdto this package that includes an index of all available docs in the do directory, similar to what Daco did in https://github.com/dart-lang/native/pull/2705/files#diff-a0842ea73f3a116eff7958fbf833dd2280c366c0d8985aa05f8e1403e0f39273 - Can you include a link from the toplevel package README to the doc directory to make these a little easier to find?
| @@ -0,0 +1,102 @@ | |||
| # Dealing with iOS/macOS API differences | |||
|
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider cross-linking this file with the "Dealing with Objective-C API versioning" file and vice versa. Due to the similarity in the title I can see some people accidentally ending up here even though they are interested in the other one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. Probably better to just combine them in that case.
Co-authored-by: Michael Goderbauer <goderbauer@google.com>
Co-authored-by: Michael Goderbauer <goderbauer@google.com>
Co-authored-by: Michael Goderbauer <goderbauer@google.com>
Co-authored-by: Michael Goderbauer <goderbauer@google.com>
Co-authored-by: Michael Goderbauer <goderbauer@google.com>
|
Looking at pkgs/ffigen/README.md, the big FAQ section should probably be pulled out into the docs directory. I think it's only in the readme because it predates the docs directory. It makes the top level readme too long, and it's not very discoverable. Some of the longer answers can also be split out into their own doc file. |
Fixes #1510
Fixes #1589
Fixes #1588