Skip to content

Conversation

@liamappelbe
Copy link
Contributor

Fixes #1510
Fixes #1589
Fixes #1588

@github-actions
Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?

This check can be disabled by tagging the PR with skip-breaking-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/objective_c/lib/src/ns_input_stream.dart

This check can be disabled by tagging the PR with skip-license-check.

@coveralls
Copy link

coveralls commented Oct 14, 2025

Coverage Status

coverage: 89.76%. remained the same
when pulling d03e9d7 on ffigen_docs
into 81ff644 on main.

Copy link
Contributor

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two overall comments:

@@ -0,0 +1,102 @@
# Dealing with iOS/macOS API differences

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider cross-linking this file with the "Dealing with Objective-C API versioning" file and vice versa. Due to the similarity in the title I can see some people accidentally ending up here even though they are interested in the other one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Probably better to just combine them in that case.

liamappelbe and others added 8 commits October 16, 2025 09:20
Co-authored-by: Michael Goderbauer <goderbauer@google.com>
Co-authored-by: Michael Goderbauer <goderbauer@google.com>
Co-authored-by: Michael Goderbauer <goderbauer@google.com>
Co-authored-by: Michael Goderbauer <goderbauer@google.com>
Co-authored-by: Michael Goderbauer <goderbauer@google.com>
@liamappelbe
Copy link
Contributor Author

Looking at pkgs/ffigen/README.md, the big FAQ section should probably be pulled out into the docs directory. I think it's only in the readme because it predates the docs directory. It makes the top level readme too long, and it's not very discoverable. Some of the longer answers can also be split out into their own doc file.

@liamappelbe liamappelbe merged commit b17023d into main Oct 15, 2025
32 checks passed
@liamappelbe liamappelbe deleted the ffigen_docs branch October 15, 2025 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

4 participants