Skip to content

Conversation

@liamappelbe
Copy link
Contributor

@liamappelbe liamappelbe commented Nov 12, 2025

The new CI step repro'd the error Stuart found, before I added the fixes: https://github.com/dart-lang/native/actions/runs/19284761993/job/55143210494

Fixes #2776

@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label Nov 12, 2025
@coveralls
Copy link

coveralls commented Nov 12, 2025

Coverage Status

coverage: 91.973% (+0.05%) from 91.924%
when pulling edacb2c on objc_warn
into 00991b9 on main.

@github-actions
Copy link

PR Health

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/objective_c/lib/src/ns_input_stream.dart

This check can be disabled by tagging the PR with skip-license-check.

API leaks ⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources
objective_c _FinalizablePointer internal.dart::_ObjCReference::new::_finalizable

This check can be disabled by tagging the PR with skip-leaking-check.

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
objective_c None 9.0.0+1 9.1.0-dev 9.0.0+1 ✔️

This check can be disabled by tagging the PR with skip-breaking-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

@liamappelbe liamappelbe merged commit d2504b3 into main Nov 12, 2025
34 checks passed
@liamappelbe liamappelbe deleted the objc_warn branch November 12, 2025 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package:ffigen package:objective_c type-infra A repository infrastructure change or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compiler warnings in objective_c.m

3 participants