Skip to content

Conversation

@liamappelbe
Copy link
Contributor

@liamappelbe liamappelbe commented Nov 13, 2025

The bindings for function foo define internal variables _foo and _fooPtr, so if there's also a fooPtr function, the names collide. This collision was not being automatically resolved because the variables were created in the function's local scope instead of the root scope.

Unrelated change: I noticed that part of the method test was commented out, so I've re-enabled it.

Fixes #2760

@github-actions
Copy link

PR Health

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/objective_c/lib/src/ns_input_stream.dart

This check can be disabled by tagging the PR with skip-license-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?

This check can be disabled by tagging the PR with skip-breaking-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

@coveralls
Copy link

coveralls commented Nov 13, 2025

Coverage Status

coverage: 87.278%. remained the same
when pulling 6303be9 on ffigen_fn_conflict
into d2504b3 on main.

@liamappelbe liamappelbe merged commit dd7125d into main Nov 13, 2025
34 checks passed
@liamappelbe liamappelbe deleted the ffigen_fn_conflict branch November 13, 2025 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ffigen] [objc] Incorrect code generation for CFStringGetPascalStringPtr

4 participants