Skip to content

Conversation

@dcharkes
Copy link
Collaborator

@dcharkes dcharkes commented May 21, 2023

Makes runProcess consistent with the ones in https://dart-review.googlesource.com/c/sdk/+/267340.

@coveralls
Copy link

coveralls commented May 22, 2023

Coverage Status

coverage: 99.472% (-0.4%) from 99.848%
when pulling 72d5604 on fix-run-process
into c614277 on main.

@auto-submit
Copy link

auto-submit bot commented May 22, 2023

auto label is removed for dart-lang/native, pr: 46, due to This PR has not met approval requirements for merging. You are a member of dart-team and need 1 more review(s) in order to merge this PR.

  • Merge guidelines: You need at least one approved review if you are already part of flutter-hackers or two member reviews if you are not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit auto-submit bot removed the autosubmit label May 22, 2023
@dcharkes dcharkes changed the title [c_compiler] Fix log processing [c_compiler] runProcess additions May 22, 2023
@dcharkes dcharkes merged commit 0c9079f into main May 22, 2023
@dcharkes dcharkes deleted the fix-run-process branch May 22, 2023 16:24
HosseinYousefi pushed a commit that referenced this pull request Nov 16, 2023
HosseinYousefi pushed a commit that referenced this pull request Nov 16, 2023
HosseinYousefi pushed a commit that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants