From 0e5c5e8c2e44ccf164c387b586a0e8b8d5a24d58 Mon Sep 17 00:00:00 2001 From: Daco Harkes Date: Wed, 14 Jun 2023 11:30:36 +0200 Subject: [PATCH] [native_assets_cli] Don't read c_compiler config if dry_run --- .../native_assets_cli/lib/src/model/build_config.dart | 5 ++++- .../test/model/build_config_test.dart | 11 +++++++++++ 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/pkgs/native_assets_cli/lib/src/model/build_config.dart b/pkgs/native_assets_cli/lib/src/model/build_config.dart index 8fdd19ae84..7570f0d6ad 100644 --- a/pkgs/native_assets_cli/lib/src/model/build_config.dart +++ b/pkgs/native_assets_cli/lib/src/model/build_config.dart @@ -464,7 +464,10 @@ class BuildConfig { } Map toYaml() { - final cCompilerYaml = _cCompiler.toYaml(); + late Map cCompilerYaml; + if (!dryRun) { + cCompilerYaml = _cCompiler.toYaml(); + } return { outDirConfigKey: _outDir.toFilePath(), diff --git a/pkgs/native_assets_cli/test/model/build_config_test.dart b/pkgs/native_assets_cli/test/model/build_config_test.dart index ec3de10125..5401f072df 100644 --- a/pkgs/native_assets_cli/test/model/build_config_test.dart +++ b/pkgs/native_assets_cli/test/model/build_config_test.dart @@ -552,4 +552,15 @@ version: ${BuildConfig.version}'''; )), ); }); + + test('BuildConfig dry_run access invalid args', () { + final buildConfig = BuildConfig.dryRun( + outDir: outDirUri, + packageRoot: tempUri, + targetOs: OS.windows, + linkModePreference: LinkModePreference.dynamic, + ); + buildConfig.toYamlString(); + // No crash. + }); }