Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports more arguments in path.join API #130

merged 4 commits into from Nov 14, 2022


Copy link

@hellohuanlin hellohuanlin commented Nov 11, 2022

When working on flutter tools, occasionally I need 9-12 parts, and it's a bit annoying to have to break them up.

Why 16 arguments? 16 should be good enough to cover most cases (based on my experience on tools repo in the past few weeks). I doubt there's a good reason for 8 either (not documented at least), so i just double it to 16.

@hellohuanlin hellohuanlin force-pushed the path_join_supports_more_args branch 5 times, most recently from f59e602 to fd0a68f Compare November 11, 2022 00:51
Copy link

kevmoo commented Nov 11, 2022

Should add a changelog entry. I'm a bit 🤷 – @natebosch ? @devoncarew ?

@hellohuanlin hellohuanlin marked this pull request as ready for review November 11, 2022 19:33
Copy link
Contributor Author

I think i need an approval to run the workflows.

@natebosch natebosch merged commit 12ce876 into dart-lang:master Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants