Zone.strong #9
Merged
Zone.strong #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevmoo
reviewed
Sep 18, 2017
pubspec.yaml
Outdated
| author: Dart Team <misc@dartlang.org> | ||
| description: A class for managing a finite pool of resources. | ||
| homepage: https://github.com/dart-lang/pool | ||
| dependencies: | ||
| async: "^1.4.0" | ||
| stack_trace: ">=0.9.2 <2.0.0" | ||
| environment: | ||
| sdk: ">=1.22.0 <2.0.0" | ||
| sdk: ">=2.0.0-dev.0.1 <2.0.0-dev.infinity" |
There was a problem hiding this comment.
2 things
- This won't be a . release. It'll be dev.1.0 – I think
- Don't need the infinity thing any more. Just <2.0.0 will work...
kevmoo
approved these changes
Sep 18, 2017
pubspec.yaml
Outdated
| author: Dart Team <misc@dartlang.org> | ||
| description: A class for managing a finite pool of resources. | ||
| homepage: https://github.com/dart-lang/pool | ||
| dependencies: | ||
| async: "^1.4.0" | ||
| stack_trace: ">=0.9.2 <2.0.0" | ||
| environment: | ||
| sdk: ">=1.22.0 <2.0.0" | ||
| sdk: ">=2.0.0-dev.0.1 <2.0.0-dev.infinity" |
|
done. |
kevmoo
requested changes
Sep 18, 2017
CHANGELOG.md
Outdated
| @@ -1,7 +1,6 @@ | |||
| ## 1.3.1 | |||
pubspec.yaml
Outdated
| @@ -1,5 +1,5 @@ | |||
| name: pool | |||
| version: 1.3.1 | |||
| version: 1.3.3 | |||
|
done. |
kevmoo
reviewed
Sep 18, 2017
lib/pool.dart
Outdated
| @@ -183,8 +183,7 @@ class Pool { | |||
| _allocatedResources--; | |||
| if (_allocatedResources == 0) _closeGroup.close(); | |||
| } else { | |||
| _onReleaseCallbacks.add( | |||
| Zone.current.bindCallback(onRelease, runGuarded: false)); | |||
| _onReleaseCallbacks.add(Zone.current.bindCallback(onRelease)); | |||
There was a problem hiding this comment.
To be super clear – we will now run these callbacks "guarded" in 1.24?
kevmoo
approved these changes
Sep 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
dart:asynczone API is in the process of becoming strong-mode clean.This patch fixes a breakage introduced by this change.