Migrate isBlocked flags to isModerated. #8356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
isoos
commented
Dec 4, 2024
isoos
commented
- Fix integrity check wrt. blocked packages #8336
- added the migration as part of the new-field pub-task, as there seems to be little reason to create a separate task for it (which will be removed and then reported as not working)
- added a test that does not use the admin action to set the flags - they can be also removed (in a separate PR)
- added the migration to be part of the post-test part of the profile-based tests, so that we can make sure we don't have any inconsistency after they run (to be extended to all periodic tasks in a follow-up PR)
jonasfj
approved these changes
Dec 4, 2024
Comment on lines
+45
to
+53
| // sync exported API(s) | ||
| await apiExporter?.synchronizePackage(entity.name!, forceDelete: true); | ||
|
|
||
| // retract or re-populate public archive files | ||
| await packageBackend.tarballStorage.updatePublicArchiveBucket( | ||
| package: entity.name!, | ||
| ageCheckThreshold: Duration.zero, | ||
| deleteIfOlder: Duration.zero, | ||
| ); |
Member
There was a problem hiding this comment.
Are we sure we want to do this? Or should we just let this happen naturally?
I don't really have any strong feelings on the subject 🤣
Collaborator
Author
There was a problem hiding this comment.
Are we sure we want to do this? Or should we just let this happen naturally?
The tests would fail with integrity checks, otherwise we could let it happen naturally. I don't mind that it happens right away.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.