From 95d4af67fbd5917e5ba936d72c269ec033c786ba Mon Sep 17 00:00:00 2001 From: Sarah Zakarias Date: Tue, 10 Dec 2024 12:17:40 +0000 Subject: [PATCH 1/2] Add seperate flag for download counts chart --- app/lib/frontend/handlers/experimental.dart | 1 + app/lib/frontend/templates/views/pkg/score_tab.dart | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/app/lib/frontend/handlers/experimental.dart b/app/lib/frontend/handlers/experimental.dart index 4c581e4d9a..18d0a9ab90 100644 --- a/app/lib/frontend/handlers/experimental.dart +++ b/app/lib/frontend/handlers/experimental.dart @@ -96,6 +96,7 @@ class ExperimentalFlags { bool get isDarkModeDefault => isEnabled('dark-as-default'); bool get showDownloadCounts => isEnabled('download-counts'); + bool get showDownloadCountsChart => isEnabled('download-counts-chart'); String encodedAsCookie() => _enabled.join(':'); diff --git a/app/lib/frontend/templates/views/pkg/score_tab.dart b/app/lib/frontend/templates/views/pkg/score_tab.dart index f9a372883f..c5d2f45050 100644 --- a/app/lib/frontend/templates/views/pkg/score_tab.dart +++ b/app/lib/frontend/templates/views/pkg/score_tab.dart @@ -80,7 +80,7 @@ d.Node scoreTabNode({ ), _reportNode(report), if (card.weeklyVersionDownloads != null && - requestContext.experimentalFlags.showDownloadCounts) + requestContext.experimentalFlags.showDownloadCountsChart) _downloadsChart(card.weeklyVersionDownloads!), if (toolEnvInfo != null) toolEnvInfo, ]), From e153f5a4b5fd08d0cbaaf0d3da4d9fbf68f0db49 Mon Sep 17 00:00:00 2001 From: Sarah Zakarias Date: Tue, 10 Dec 2024 12:22:17 +0000 Subject: [PATCH 2/2] change name --- app/lib/frontend/handlers/experimental.dart | 3 ++- app/lib/frontend/templates/views/pkg/score_tab.dart | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/app/lib/frontend/handlers/experimental.dart b/app/lib/frontend/handlers/experimental.dart index 18d0a9ab90..aba6d8b0bc 100644 --- a/app/lib/frontend/handlers/experimental.dart +++ b/app/lib/frontend/handlers/experimental.dart @@ -96,7 +96,8 @@ class ExperimentalFlags { bool get isDarkModeDefault => isEnabled('dark-as-default'); bool get showDownloadCounts => isEnabled('download-counts'); - bool get showDownloadCountsChart => isEnabled('download-counts-chart'); + bool get showDownloadCountsVersionChart => + isEnabled('download-counts-version-chart'); String encodedAsCookie() => _enabled.join(':'); diff --git a/app/lib/frontend/templates/views/pkg/score_tab.dart b/app/lib/frontend/templates/views/pkg/score_tab.dart index c5d2f45050..12f8bc2ecf 100644 --- a/app/lib/frontend/templates/views/pkg/score_tab.dart +++ b/app/lib/frontend/templates/views/pkg/score_tab.dart @@ -80,7 +80,7 @@ d.Node scoreTabNode({ ), _reportNode(report), if (card.weeklyVersionDownloads != null && - requestContext.experimentalFlags.showDownloadCountsChart) + requestContext.experimentalFlags.showDownloadCountsVersionChart) _downloadsChart(card.weeklyVersionDownloads!), if (toolEnvInfo != null) toolEnvInfo, ]),