From 763bc0558f8be17481d5ff398c8150471b9e9c09 Mon Sep 17 00:00:00 2001 From: Istvan Soos Date: Thu, 12 Dec 2024 12:09:50 +0100 Subject: [PATCH] Fix email commas. --- app/lib/service/email/email_templates.dart | 3 +++ app/test/service/email/email_templates_test.dart | 4 ++++ 2 files changed, 7 insertions(+) diff --git a/app/lib/service/email/email_templates.dart b/app/lib/service/email/email_templates.dart index 8acc33861f..81e0b900dc 100644 --- a/app/lib/service/email/email_templates.dart +++ b/app/lib/service/email/email_templates.dart @@ -86,6 +86,9 @@ bool isValidEmail(String email) { // strict pattern check if (!_strictEmailRegExp.hasMatch(email)) return false; + // also reject commas + if (email.contains(',')) return false; + // checking for IPv4 or IPv6 addresses var isInternetAddress = false; try { diff --git a/app/test/service/email/email_templates_test.dart b/app/test/service/email/email_templates_test.dart index d756c6a883..adcd973cd3 100644 --- a/app/test/service/email/email_templates_test.dart +++ b/app/test/service/email/email_templates_test.dart @@ -98,6 +98,10 @@ void main() { // verify that we have rejected emails expect(rejectedEmails, hasLength(215)); }); + + test('reject multiple addresses', () { + expect(isValidEmail('abc@example.com,efg@example.com'), false); + }); }); group('EmailAddress format', () {