From b2a6f91a81531676179313802b320f09c3beaadc Mon Sep 17 00:00:00 2001 From: Istvan Soos Date: Tue, 21 Jan 2025 16:38:13 +0100 Subject: [PATCH] Fix ARIA attributes for x-ago texts. --- app/lib/frontend/dom/dom.dart | 7 ++++-- .../frontend/golden/my_activity_log_page.html | 24 +++++++++---------- .../frontend/golden/my_liked_packages.html | 6 ++--- app/test/frontend/golden/my_packages.html | 8 +++---- app/test/frontend/golden/my_publishers.html | 4 ++-- .../golden/pkg_activity_log_page.html | 14 +++++------ app/test/frontend/golden/pkg_admin_page.html | 2 +- .../frontend/golden/pkg_changelog_page.html | 2 +- .../frontend/golden/pkg_example_page.html | 2 +- app/test/frontend/golden/pkg_index_page.html | 6 ++--- .../frontend/golden/pkg_install_page.html | 2 +- app/test/frontend/golden/pkg_score_page.html | 4 ++-- .../pkg_score_page_with_downloads_chart.html | 4 ++-- app/test/frontend/golden/pkg_show_page.html | 2 +- .../golden/pkg_show_page_discontinued.html | 2 +- .../golden/pkg_show_page_flutter_plugin.html | 2 +- .../golden/pkg_show_page_publisher.html | 2 +- .../golden/pkg_show_page_retracted.html | 2 +- ..._page_retracted_non_retracted_version.html | 2 +- .../golden/pkg_show_version_page.html | 2 +- .../frontend/golden/pkg_versions_page.html | 10 ++++---- .../golden/publisher_activity_log_page.html | 6 ++--- .../frontend/golden/publisher_admin_page.html | 2 +- .../frontend/golden/publisher_list_page.html | 4 ++-- .../golden/publisher_packages_page.html | 6 ++--- .../publisher_unlisted_packages_page.html | 6 ++--- app/test/frontend/golden/search_page.html | 6 ++--- .../testdata/goldens/packages/oxygen.html | 2 +- .../goldens/packages/oxygen/changelog.html | 2 +- .../goldens/packages/oxygen/example.html | 2 +- .../goldens/packages/oxygen/install.html | 2 +- .../goldens/packages/oxygen/license.html | 2 +- .../goldens/packages/oxygen/score.html | 4 ++-- .../goldens/packages/oxygen/versions.html | 6 ++--- .../packages/oxygen/versions/1.0.0.html | 2 +- .../oxygen/versions/1.0.0/changelog.html | 2 +- .../oxygen/versions/1.0.0/example.html | 2 +- .../oxygen/versions/1.0.0/install.html | 2 +- .../oxygen/versions/1.0.0/license.html | 2 +- .../packages/oxygen/versions/1.0.0/score.html | 4 ++-- .../packages/oxygen/versions/2.0.0.html | 2 +- 41 files changed, 89 insertions(+), 86 deletions(-) diff --git a/app/lib/frontend/dom/dom.dart b/app/lib/frontend/dom/dom.dart index c180c94c26..07e3a1945e 100644 --- a/app/lib/frontend/dom/dom.dart +++ b/app/lib/frontend/dom/dom.dart @@ -109,8 +109,11 @@ Node xAgoTimestamp(DateTime timestamp, {String? datePrefix}) { href: '', title: title, attributes: { - 'aria-label': text, - 'aria-role': 'button', + // Note: We change the `text` and the `title` when the user clicks this button. + // We do not use `aria-label`, so that the screenreader will read the + // appropriate change. + // We do not use `aria-pressed`, so that the screenreader will not read + // "toggle button pressed" as part of the text. 'role': 'button', 'data-timestamp': timestamp.millisecondsSinceEpoch.toString(), }, diff --git a/app/test/frontend/golden/my_activity_log_page.html b/app/test/frontend/golden/my_activity_log_page.html index 59947e9625..b97e2cf28a 100644 --- a/app/test/frontend/golden/my_activity_log_page.html +++ b/app/test/frontend/golden/my_activity_log_page.html @@ -146,7 +146,7 @@

admin

admin@pub.dev

Joined - %%x-ago%% + %%x-ago%%

@@ -185,7 +185,7 @@

admin

- %%x-ago%% + %%x-ago%%
@@ -203,7 +203,7 @@

admin

- %%x-ago%% + %%x-ago%%
@@ -221,7 +221,7 @@

admin

- %%x-ago%% + %%x-ago%%
@@ -239,7 +239,7 @@

admin

- %%x-ago%% + %%x-ago%%
@@ -255,7 +255,7 @@

admin

- %%x-ago%% + %%x-ago%%
@@ -273,7 +273,7 @@

admin

- %%x-ago%% + %%x-ago%%
@@ -291,7 +291,7 @@

admin

- %%x-ago%% + %%x-ago%%
@@ -307,7 +307,7 @@

admin

- %%x-ago%% + %%x-ago%%
@@ -325,7 +325,7 @@

admin

- %%x-ago%% + %%x-ago%%
@@ -341,7 +341,7 @@

admin

- %%x-ago%% + %%x-ago%%
@@ -359,7 +359,7 @@

admin

- %%x-ago%% + %%x-ago%%
diff --git a/app/test/frontend/golden/my_liked_packages.html b/app/test/frontend/golden/my_liked_packages.html index d4d547d318..95c1fdecfd 100644 --- a/app/test/frontend/golden/my_liked_packages.html +++ b/app/test/frontend/golden/my_liked_packages.html @@ -147,7 +147,7 @@

user

user@pub.dev

Joined - %%x-ago%% + %%x-ago%%

@@ -192,7 +192,7 @@

@@ -210,7 +210,7 @@

diff --git a/app/test/frontend/golden/my_packages.html b/app/test/frontend/golden/my_packages.html index 321ef6c198..3db3aa8ab1 100644 --- a/app/test/frontend/golden/my_packages.html +++ b/app/test/frontend/golden/my_packages.html @@ -146,7 +146,7 @@

user

user@pub.dev

Joined - %%x-ago%% + %%x-ago%%

@@ -232,11 +232,11 @@

v 1.2.0 ( - %%x-ago%% + %%x-ago%% ) / 2.0.0-dev ( - %%x-ago%% + %%x-ago%% )

@@ -181,7 +181,7 @@

Registered - %%x-ago%% + %%x-ago%% .

diff --git a/app/test/frontend/golden/pkg_activity_log_page.html b/app/test/frontend/golden/pkg_activity_log_page.html index 7546028f60..511f02642a 100644 --- a/app/test/frontend/golden/pkg_activity_log_page.html +++ b/app/test/frontend/golden/pkg_activity_log_page.html @@ -153,7 +153,7 @@