From 0e363b92529b2f3c3bde3ca57eb6f2b27e2df0a8 Mon Sep 17 00:00:00 2001 From: Istvan Soos Date: Fri, 24 Jan 2025 17:58:11 +0100 Subject: [PATCH 1/2] Dark mode link hover: increase brightness instead lower opacity. --- pkg/web_css/lib/src/_variables.scss | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/pkg/web_css/lib/src/_variables.scss b/pkg/web_css/lib/src/_variables.scss index d3aa944f50..4a9ff7080e 100644 --- a/pkg/web_css/lib/src/_variables.scss +++ b/pkg/web_css/lib/src/_variables.scss @@ -242,6 +242,13 @@ .displayed-in-light-theme { display: none !important; } + + a { + &:hover { + opacity: 1.0; + filter: brightness(120%); + } + } } @mixin elevated-content-border { From 588bae24b0b6d08d32ef9c4eac3cabecdfe50011 Mon Sep 17 00:00:00 2001 From: Istvan Soos Date: Mon, 27 Jan 2025 13:19:24 +0100 Subject: [PATCH 2/2] Refactor styles into _base.scss --- pkg/web_css/lib/src/_base.scss | 19 ++++++++++++++----- pkg/web_css/lib/src/_variables.scss | 7 ------- 2 files changed, 14 insertions(+), 12 deletions(-) diff --git a/pkg/web_css/lib/src/_base.scss b/pkg/web_css/lib/src/_base.scss index 831b7b8c2d..32288bd0df 100644 --- a/pkg/web_css/lib/src/_base.scss +++ b/pkg/web_css/lib/src/_base.scss @@ -93,11 +93,6 @@ a { text-decoration: none; color: var(--pub-link-text-color); cursor: pointer; - opacity: 1; - - &:hover { - opacity: 0.8; - } // TODO: fix style to not use bgColor as text and text color as background &.link-button { @@ -106,6 +101,20 @@ a { display: inline-block; padding: 4px 12px; } + + .light-theme & { + opacity: 1; + + &:hover { + opacity: 0.8; + } + } + + .dark-theme & { + &:hover { + filter: brightness(120%); + } + } } main { diff --git a/pkg/web_css/lib/src/_variables.scss b/pkg/web_css/lib/src/_variables.scss index 4a9ff7080e..d3aa944f50 100644 --- a/pkg/web_css/lib/src/_variables.scss +++ b/pkg/web_css/lib/src/_variables.scss @@ -242,13 +242,6 @@ .displayed-in-light-theme { display: none !important; } - - a { - &:hover { - opacity: 1.0; - filter: brightness(120%); - } - } } @mixin elevated-content-border {