From e841b17f66bca8b8d1e569841f104407e832dbac Mon Sep 17 00:00:00 2001 From: Parker Lougheed Date: Sun, 2 Feb 2025 20:32:42 -0600 Subject: [PATCH 1/2] Increase contrast of pub detail tags in dark mode --- pkg/web_css/lib/src/_variables.scss | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pkg/web_css/lib/src/_variables.scss b/pkg/web_css/lib/src/_variables.scss index d3aa944f50..87bff8f815 100644 --- a/pkg/web_css/lib/src/_variables.scss +++ b/pkg/web_css/lib/src/_variables.scss @@ -152,13 +152,14 @@ --pub-color-darkGunmetal: #242b32; --pub-color-darkGray: #2f3034; /* derived from dark black by making it lighter */ --pub-color-nipponUltraBlue: #23607f; + --pub-color-darkSteelBlue: #144466; --pub-neutral-bgColor: var(--pub-color-darkBlack); --pub-neutral-borderColor: var(--pub-color-darkGunmetal); --pub-neutral-textColor: var(--dash-surface-fgColor); --pub-neutral-hover-bgColor: var(--pub-color-darkGray); --pub-inset-bgColor: var(--pub-color-darkGunmetal); - --pub-selected-bgColor: var(--pub-color-nipponUltraBlue); + --pub-selected-bgColor: var(--pub-color-darkSteelBlue); // Note: these colors are copied from GitHub styles --pub-markdown-alert-note: #0969da; // accent-emphasis from GitHub @@ -189,7 +190,7 @@ --pub-sort_control_hover-text-color: var(--pub-neutral-textColor); --pub-sort_control_selected-text-color: var(--pub-neutral-textColor); --pub-tag_simplebadge-text-color: var(--pub-neutral-textColor); - --pub-tag_sdkbadge-separator-color: var(--pub-neutral-textColor); + --pub-tag_sdkbadge-separator-color: #226699; --pub-tag_sdkbadge-text-color: var(--pub-neutral-textColor); --pub-downloads-chart-frame-color: #55585a; From 7d17085a563e60069d4f587c3d0447bde122d855 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Istv=C3=A1n=20So=C3=B3s?= Date: Mon, 3 Feb 2025 08:20:04 +0100 Subject: [PATCH 2/2] remove nipponUltraBlue --- pkg/web_css/lib/src/_variables.scss | 1 - 1 file changed, 1 deletion(-) diff --git a/pkg/web_css/lib/src/_variables.scss b/pkg/web_css/lib/src/_variables.scss index 87bff8f815..1b7ec8788a 100644 --- a/pkg/web_css/lib/src/_variables.scss +++ b/pkg/web_css/lib/src/_variables.scss @@ -151,7 +151,6 @@ --pub-color-darkBlack: #121317; --pub-color-darkGunmetal: #242b32; --pub-color-darkGray: #2f3034; /* derived from dark black by making it lighter */ - --pub-color-nipponUltraBlue: #23607f; --pub-color-darkSteelBlue: #144466; --pub-neutral-bgColor: var(--pub-color-darkBlack);