From a14b821723ac127a8b90cfcc5bc77600c6f839bb Mon Sep 17 00:00:00 2001 From: Istvan Soos Date: Mon, 10 Feb 2025 12:22:41 +0100 Subject: [PATCH] Enable experiments --- app/lib/frontend/handlers/experimental.dart | 7 +++--- .../templates/views/shared/layout.dart | 2 -- app/test/frontend/golden/authorized_page.html | 1 + app/test/frontend/golden/consent_page.html | 1 + .../golden/create_publisher_page.html | 1 + app/test/frontend/golden/error_page.html | 3 ++- app/test/frontend/golden/help_page.html | 1 + app/test/frontend/golden/landing_page.html | 3 ++- .../frontend/golden/my_activity_log_page.html | 1 + .../frontend/golden/my_liked_packages.html | 1 + app/test/frontend/golden/my_packages.html | 1 + app/test/frontend/golden/my_publishers.html | 1 + .../golden/pkg_activity_log_page.html | 1 + app/test/frontend/golden/pkg_admin_page.html | 1 + .../frontend/golden/pkg_changelog_page.html | 1 + .../frontend/golden/pkg_example_page.html | 1 + app/test/frontend/golden/pkg_index_page.html | 3 ++- .../frontend/golden/pkg_install_page.html | 1 + app/test/frontend/golden/pkg_score_page.html | 23 +++++++++++++++++++ .../pkg_score_page_with_downloads_chart.html | 23 +++++++++++++++++++ app/test/frontend/golden/pkg_show_page.html | 1 + .../golden/pkg_show_page_discontinued.html | 1 + .../golden/pkg_show_page_flutter_plugin.html | 1 + .../golden/pkg_show_page_publisher.html | 1 + .../golden/pkg_show_page_retracted.html | 1 + ..._page_retracted_non_retracted_version.html | 1 + .../golden/pkg_show_version_page.html | 1 + .../frontend/golden/pkg_versions_page.html | 1 + .../golden/publisher_activity_log_page.html | 3 ++- .../frontend/golden/publisher_admin_page.html | 3 ++- .../frontend/golden/publisher_list_page.html | 3 ++- .../golden/publisher_packages_page.html | 3 ++- .../publisher_unlisted_packages_page.html | 3 ++- app/test/frontend/golden/report_page.html | 1 + .../frontend/golden/report_page_appeal.html | 1 + app/test/frontend/golden/search_page.html | 3 ++- app/test/frontend/golden/topics_page.html | 1 + app/test/frontend/templates_test.dart | 2 ++ .../testdata/goldens/packages/oxygen.html | 1 + .../goldens/packages/oxygen/changelog.html | 1 + .../goldens/packages/oxygen/example.html | 1 + .../goldens/packages/oxygen/install.html | 1 + .../goldens/packages/oxygen/license.html | 1 + .../goldens/packages/oxygen/score.html | 1 + .../goldens/packages/oxygen/versions.html | 1 + .../packages/oxygen/versions/1.0.0.html | 1 + .../oxygen/versions/1.0.0/changelog.html | 1 + .../oxygen/versions/1.0.0/example.html | 1 + .../oxygen/versions/1.0.0/install.html | 1 + .../oxygen/versions/1.0.0/license.html | 1 + .../packages/oxygen/versions/1.0.0/score.html | 1 + .../packages/oxygen/versions/2.0.0.html | 1 + static/js/dark-init.js | 4 ---- 53 files changed, 107 insertions(+), 19 deletions(-) diff --git a/app/lib/frontend/handlers/experimental.dart b/app/lib/frontend/handlers/experimental.dart index 588a42c1e4..f42da4d181 100644 --- a/app/lib/frontend/handlers/experimental.dart +++ b/app/lib/frontend/handlers/experimental.dart @@ -92,14 +92,13 @@ class ExperimentalFlags { return params; } - bool get isSearchCompletionEnabled => isEnabled('search-completion'); + bool get isSearchCompletionEnabled => true; bool get isSearchTopicsEnabled => isEnabled('search-topics'); - bool get isDarkModeEnabled => isEnabled('dark'); + bool get isDarkModeEnabled => true; bool get isDarkModeDefault => isEnabled('dark-as-default'); - bool get showDownloadCountsVersionChart => - isEnabled('download-counts-version-chart'); + bool get showDownloadCountsVersionChart => true; String encodedAsCookie() => _enabled.join(':'); diff --git a/app/lib/frontend/templates/views/shared/layout.dart b/app/lib/frontend/templates/views/shared/layout.dart index 500f487bd8..d49b4412bf 100644 --- a/app/lib/frontend/templates/views/shared/layout.dart +++ b/app/lib/frontend/templates/views/shared/layout.dart @@ -161,8 +161,6 @@ d.Node pageLayoutNode({ 'body', classes: [ ...?bodyClasses, - if (requestContext.experimentalFlags.isDarkModeEnabled) - '-experimental-dark-mode', requestContext.experimentalFlags.isDarkModeDefault ? 'dark-theme' : 'light-theme', diff --git a/app/test/frontend/golden/authorized_page.html b/app/test/frontend/golden/authorized_page.html index 294083d1e3..bbe30a300a 100644 --- a/app/test/frontend/golden/authorized_page.html +++ b/app/test/frontend/golden/authorized_page.html @@ -104,6 +104,7 @@

+
diff --git a/app/test/frontend/golden/consent_page.html b/app/test/frontend/golden/consent_page.html index afb9c46abc..765e55a538 100644 --- a/app/test/frontend/golden/consent_page.html +++ b/app/test/frontend/golden/consent_page.html @@ -104,6 +104,7 @@

+
diff --git a/app/test/frontend/golden/create_publisher_page.html b/app/test/frontend/golden/create_publisher_page.html index f781b488e9..33d0f896e4 100644 --- a/app/test/frontend/golden/create_publisher_page.html +++ b/app/test/frontend/golden/create_publisher_page.html @@ -103,6 +103,7 @@

+
diff --git a/app/test/frontend/golden/error_page.html b/app/test/frontend/golden/error_page.html index 369bff036c..022d4d240e 100644 --- a/app/test/frontend/golden/error_page.html +++ b/app/test/frontend/golden/error_page.html @@ -98,12 +98,13 @@

+
diff --git a/app/test/frontend/golden/help_page.html b/app/test/frontend/golden/help_page.html index dad3fcddc6..1350faeb84 100644 --- a/app/test/frontend/golden/help_page.html +++ b/app/test/frontend/golden/help_page.html @@ -104,6 +104,7 @@

+
diff --git a/app/test/frontend/golden/landing_page.html b/app/test/frontend/golden/landing_page.html index 6499ab95d3..a5fd627a94 100644 --- a/app/test/frontend/golden/landing_page.html +++ b/app/test/frontend/golden/landing_page.html @@ -98,6 +98,7 @@

+
@@ -105,7 +106,7 @@

pub.dev package manager

diff --git a/app/test/frontend/golden/my_activity_log_page.html b/app/test/frontend/golden/my_activity_log_page.html index 3c1871517d..c9b03646de 100644 --- a/app/test/frontend/golden/my_activity_log_page.html +++ b/app/test/frontend/golden/my_activity_log_page.html @@ -130,6 +130,7 @@

+
diff --git a/app/test/frontend/golden/my_liked_packages.html b/app/test/frontend/golden/my_liked_packages.html index 1292314886..e98d8a459b 100644 --- a/app/test/frontend/golden/my_liked_packages.html +++ b/app/test/frontend/golden/my_liked_packages.html @@ -131,6 +131,7 @@

+
diff --git a/app/test/frontend/golden/my_packages.html b/app/test/frontend/golden/my_packages.html index 5fa8c8f7b7..9e8db53237 100644 --- a/app/test/frontend/golden/my_packages.html +++ b/app/test/frontend/golden/my_packages.html @@ -130,6 +130,7 @@

+
diff --git a/app/test/frontend/golden/my_publishers.html b/app/test/frontend/golden/my_publishers.html index 56e21c7999..f3818e53b5 100644 --- a/app/test/frontend/golden/my_publishers.html +++ b/app/test/frontend/golden/my_publishers.html @@ -130,6 +130,7 @@

+
diff --git a/app/test/frontend/golden/pkg_activity_log_page.html b/app/test/frontend/golden/pkg_activity_log_page.html index ee5705b101..77032c7aa0 100644 --- a/app/test/frontend/golden/pkg_activity_log_page.html +++ b/app/test/frontend/golden/pkg_activity_log_page.html @@ -132,6 +132,7 @@

+
diff --git a/app/test/frontend/golden/pkg_admin_page.html b/app/test/frontend/golden/pkg_admin_page.html index 5759a7ffdd..c7afdb8dc9 100644 --- a/app/test/frontend/golden/pkg_admin_page.html +++ b/app/test/frontend/golden/pkg_admin_page.html @@ -132,6 +132,7 @@

+
diff --git a/app/test/frontend/golden/pkg_changelog_page.html b/app/test/frontend/golden/pkg_changelog_page.html index 8ed3a67766..b3769adfb3 100644 --- a/app/test/frontend/golden/pkg_changelog_page.html +++ b/app/test/frontend/golden/pkg_changelog_page.html @@ -106,6 +106,7 @@

+
diff --git a/app/test/frontend/golden/pkg_example_page.html b/app/test/frontend/golden/pkg_example_page.html index f4879c167c..098d8400a7 100644 --- a/app/test/frontend/golden/pkg_example_page.html +++ b/app/test/frontend/golden/pkg_example_page.html @@ -106,6 +106,7 @@

+
diff --git a/app/test/frontend/golden/pkg_index_page.html b/app/test/frontend/golden/pkg_index_page.html index c6ccd4ae16..a053b22404 100644 --- a/app/test/frontend/golden/pkg_index_page.html +++ b/app/test/frontend/golden/pkg_index_page.html @@ -99,12 +99,13 @@

+
+
diff --git a/app/test/frontend/golden/pkg_score_page.html b/app/test/frontend/golden/pkg_score_page.html index 003d4219a4..8b878a2c52 100644 --- a/app/test/frontend/golden/pkg_score_page.html +++ b/app/test/frontend/golden/pkg_score_page.html @@ -106,6 +106,7 @@

+
@@ -305,6 +306,28 @@

analysis log for details.

+

Weekly downloads

+
+
+ Display as: + + + + +
+
+
+
+ By versions: + + + + + + +
+
+
diff --git a/app/test/frontend/golden/pkg_score_page_with_downloads_chart.html b/app/test/frontend/golden/pkg_score_page_with_downloads_chart.html index 003d4219a4..8b878a2c52 100644 --- a/app/test/frontend/golden/pkg_score_page_with_downloads_chart.html +++ b/app/test/frontend/golden/pkg_score_page_with_downloads_chart.html @@ -106,6 +106,7 @@

+
@@ -305,6 +306,28 @@

analysis log for details.

+

Weekly downloads

+
+
+ Display as: + + + + +
+
+
+
+ By versions: + + + + + + +
+
+
diff --git a/app/test/frontend/golden/pkg_show_page.html b/app/test/frontend/golden/pkg_show_page.html index 3e15aa90f8..a1c0b4b522 100644 --- a/app/test/frontend/golden/pkg_show_page.html +++ b/app/test/frontend/golden/pkg_show_page.html @@ -106,6 +106,7 @@

+
diff --git a/app/test/frontend/golden/pkg_show_page_discontinued.html b/app/test/frontend/golden/pkg_show_page_discontinued.html index ee848525a3..016f289cd0 100644 --- a/app/test/frontend/golden/pkg_show_page_discontinued.html +++ b/app/test/frontend/golden/pkg_show_page_discontinued.html @@ -106,6 +106,7 @@

+
diff --git a/app/test/frontend/golden/pkg_show_page_flutter_plugin.html b/app/test/frontend/golden/pkg_show_page_flutter_plugin.html index 122850b604..7bfd5f5e48 100644 --- a/app/test/frontend/golden/pkg_show_page_flutter_plugin.html +++ b/app/test/frontend/golden/pkg_show_page_flutter_plugin.html @@ -106,6 +106,7 @@

+
diff --git a/app/test/frontend/golden/pkg_show_page_publisher.html b/app/test/frontend/golden/pkg_show_page_publisher.html index 257b45d9c9..68d331bb2f 100644 --- a/app/test/frontend/golden/pkg_show_page_publisher.html +++ b/app/test/frontend/golden/pkg_show_page_publisher.html @@ -106,6 +106,7 @@

+
diff --git a/app/test/frontend/golden/pkg_show_page_retracted.html b/app/test/frontend/golden/pkg_show_page_retracted.html index 8b68486520..dbd21f7daf 100644 --- a/app/test/frontend/golden/pkg_show_page_retracted.html +++ b/app/test/frontend/golden/pkg_show_page_retracted.html @@ -106,6 +106,7 @@

+
diff --git a/app/test/frontend/golden/pkg_show_page_retracted_non_retracted_version.html b/app/test/frontend/golden/pkg_show_page_retracted_non_retracted_version.html index 0a6498f2c1..9d1103ccad 100644 --- a/app/test/frontend/golden/pkg_show_page_retracted_non_retracted_version.html +++ b/app/test/frontend/golden/pkg_show_page_retracted_non_retracted_version.html @@ -106,6 +106,7 @@

+
diff --git a/app/test/frontend/golden/pkg_show_version_page.html b/app/test/frontend/golden/pkg_show_version_page.html index 5661fa60d9..22a5e9d879 100644 --- a/app/test/frontend/golden/pkg_show_version_page.html +++ b/app/test/frontend/golden/pkg_show_version_page.html @@ -106,6 +106,7 @@

+
diff --git a/app/test/frontend/golden/pkg_versions_page.html b/app/test/frontend/golden/pkg_versions_page.html index 7d19af57fd..b557fbda76 100644 --- a/app/test/frontend/golden/pkg_versions_page.html +++ b/app/test/frontend/golden/pkg_versions_page.html @@ -106,6 +106,7 @@

+
diff --git a/app/test/frontend/golden/publisher_activity_log_page.html b/app/test/frontend/golden/publisher_activity_log_page.html index 4a818917d9..6df685f98d 100644 --- a/app/test/frontend/golden/publisher_activity_log_page.html +++ b/app/test/frontend/golden/publisher_activity_log_page.html @@ -100,12 +100,13 @@

+
- +
diff --git a/app/test/frontend/golden/publisher_admin_page.html b/app/test/frontend/golden/publisher_admin_page.html index bdb7f8dcf4..1590dc05fc 100644 --- a/app/test/frontend/golden/publisher_admin_page.html +++ b/app/test/frontend/golden/publisher_admin_page.html @@ -100,12 +100,13 @@

+
diff --git a/app/test/frontend/golden/publisher_list_page.html b/app/test/frontend/golden/publisher_list_page.html index df98af1042..f632766c46 100644 --- a/app/test/frontend/golden/publisher_list_page.html +++ b/app/test/frontend/golden/publisher_list_page.html @@ -99,12 +99,13 @@

+
+
- +
diff --git a/app/test/frontend/golden/publisher_unlisted_packages_page.html b/app/test/frontend/golden/publisher_unlisted_packages_page.html index 140f6385c9..4a670eb17e 100644 --- a/app/test/frontend/golden/publisher_unlisted_packages_page.html +++ b/app/test/frontend/golden/publisher_unlisted_packages_page.html @@ -100,12 +100,13 @@

+
diff --git a/app/test/frontend/golden/report_page.html b/app/test/frontend/golden/report_page.html index 457750ec18..1ac2eac18d 100644 --- a/app/test/frontend/golden/report_page.html +++ b/app/test/frontend/golden/report_page.html @@ -103,6 +103,7 @@

+
diff --git a/app/test/frontend/golden/report_page_appeal.html b/app/test/frontend/golden/report_page_appeal.html index 884872235e..e42151b6ce 100644 --- a/app/test/frontend/golden/report_page_appeal.html +++ b/app/test/frontend/golden/report_page_appeal.html @@ -103,6 +103,7 @@

+
diff --git a/app/test/frontend/golden/search_page.html b/app/test/frontend/golden/search_page.html index 33197c514c..3ddbdbf634 100644 --- a/app/test/frontend/golden/search_page.html +++ b/app/test/frontend/golden/search_page.html @@ -99,12 +99,13 @@

+
+
diff --git a/app/test/frontend/templates_test.dart b/app/test/frontend/templates_test.dart index 436cc37bde..03651da6b2 100644 --- a/app/test/frontend/templates_test.dart +++ b/app/test/frontend/templates_test.dart @@ -101,6 +101,8 @@ void main() { 'Dart %%stable-dart-version%%') .replaceAll( '/static/hash-${staticFileCache.etag}/', '/static/hash-%%etag%%/') + .replaceAll(RegExp('data-downloads-chart-points=".*?"'), + 'data-downloads-chart-points="%%downloads-chart-points%%"') .replaceAll(RegExp('data-weekly-sparkline-points=".*?"'), 'data-weekly-sparkline-points="%%sparkline-points%%"'); final csrfToken = requestContext.sessionData?.csrfToken; diff --git a/app/test/task/testdata/goldens/packages/oxygen.html b/app/test/task/testdata/goldens/packages/oxygen.html index 6e4bde9d02..3b9fcb2c3a 100644 --- a/app/test/task/testdata/goldens/packages/oxygen.html +++ b/app/test/task/testdata/goldens/packages/oxygen.html @@ -106,6 +106,7 @@

+
diff --git a/app/test/task/testdata/goldens/packages/oxygen/changelog.html b/app/test/task/testdata/goldens/packages/oxygen/changelog.html index 703c538e6b..c721678457 100644 --- a/app/test/task/testdata/goldens/packages/oxygen/changelog.html +++ b/app/test/task/testdata/goldens/packages/oxygen/changelog.html @@ -106,6 +106,7 @@

+
diff --git a/app/test/task/testdata/goldens/packages/oxygen/example.html b/app/test/task/testdata/goldens/packages/oxygen/example.html index 1def3c7395..f68a55d6d6 100644 --- a/app/test/task/testdata/goldens/packages/oxygen/example.html +++ b/app/test/task/testdata/goldens/packages/oxygen/example.html @@ -106,6 +106,7 @@

+
diff --git a/app/test/task/testdata/goldens/packages/oxygen/install.html b/app/test/task/testdata/goldens/packages/oxygen/install.html index 745a1275eb..819ada97b5 100644 --- a/app/test/task/testdata/goldens/packages/oxygen/install.html +++ b/app/test/task/testdata/goldens/packages/oxygen/install.html @@ -106,6 +106,7 @@

+
diff --git a/app/test/task/testdata/goldens/packages/oxygen/license.html b/app/test/task/testdata/goldens/packages/oxygen/license.html index 04b1cb3de2..6b7d039452 100644 --- a/app/test/task/testdata/goldens/packages/oxygen/license.html +++ b/app/test/task/testdata/goldens/packages/oxygen/license.html @@ -106,6 +106,7 @@

+
diff --git a/app/test/task/testdata/goldens/packages/oxygen/score.html b/app/test/task/testdata/goldens/packages/oxygen/score.html index 5c758ac06b..2e18227e56 100644 --- a/app/test/task/testdata/goldens/packages/oxygen/score.html +++ b/app/test/task/testdata/goldens/packages/oxygen/score.html @@ -106,6 +106,7 @@

+
diff --git a/app/test/task/testdata/goldens/packages/oxygen/versions.html b/app/test/task/testdata/goldens/packages/oxygen/versions.html index 364de2fe36..11704b2404 100644 --- a/app/test/task/testdata/goldens/packages/oxygen/versions.html +++ b/app/test/task/testdata/goldens/packages/oxygen/versions.html @@ -106,6 +106,7 @@

+
diff --git a/app/test/task/testdata/goldens/packages/oxygen/versions/1.0.0.html b/app/test/task/testdata/goldens/packages/oxygen/versions/1.0.0.html index b465f7b560..76a0aabe4e 100644 --- a/app/test/task/testdata/goldens/packages/oxygen/versions/1.0.0.html +++ b/app/test/task/testdata/goldens/packages/oxygen/versions/1.0.0.html @@ -106,6 +106,7 @@

+
diff --git a/app/test/task/testdata/goldens/packages/oxygen/versions/1.0.0/changelog.html b/app/test/task/testdata/goldens/packages/oxygen/versions/1.0.0/changelog.html index be5f40f355..53bd9e85cd 100644 --- a/app/test/task/testdata/goldens/packages/oxygen/versions/1.0.0/changelog.html +++ b/app/test/task/testdata/goldens/packages/oxygen/versions/1.0.0/changelog.html @@ -106,6 +106,7 @@

+
diff --git a/app/test/task/testdata/goldens/packages/oxygen/versions/1.0.0/example.html b/app/test/task/testdata/goldens/packages/oxygen/versions/1.0.0/example.html index 5bbec6a913..1428b04d36 100644 --- a/app/test/task/testdata/goldens/packages/oxygen/versions/1.0.0/example.html +++ b/app/test/task/testdata/goldens/packages/oxygen/versions/1.0.0/example.html @@ -106,6 +106,7 @@

+
diff --git a/app/test/task/testdata/goldens/packages/oxygen/versions/1.0.0/install.html b/app/test/task/testdata/goldens/packages/oxygen/versions/1.0.0/install.html index db54be93b4..a2048dc909 100644 --- a/app/test/task/testdata/goldens/packages/oxygen/versions/1.0.0/install.html +++ b/app/test/task/testdata/goldens/packages/oxygen/versions/1.0.0/install.html @@ -106,6 +106,7 @@

+
diff --git a/app/test/task/testdata/goldens/packages/oxygen/versions/1.0.0/license.html b/app/test/task/testdata/goldens/packages/oxygen/versions/1.0.0/license.html index d749fe6c9d..a4dae75beb 100644 --- a/app/test/task/testdata/goldens/packages/oxygen/versions/1.0.0/license.html +++ b/app/test/task/testdata/goldens/packages/oxygen/versions/1.0.0/license.html @@ -106,6 +106,7 @@

+
diff --git a/app/test/task/testdata/goldens/packages/oxygen/versions/1.0.0/score.html b/app/test/task/testdata/goldens/packages/oxygen/versions/1.0.0/score.html index a783e0a255..e447474231 100644 --- a/app/test/task/testdata/goldens/packages/oxygen/versions/1.0.0/score.html +++ b/app/test/task/testdata/goldens/packages/oxygen/versions/1.0.0/score.html @@ -106,6 +106,7 @@

+
diff --git a/app/test/task/testdata/goldens/packages/oxygen/versions/2.0.0.html b/app/test/task/testdata/goldens/packages/oxygen/versions/2.0.0.html index 6e4bde9d02..3b9fcb2c3a 100644 --- a/app/test/task/testdata/goldens/packages/oxygen/versions/2.0.0.html +++ b/app/test/task/testdata/goldens/packages/oxygen/versions/2.0.0.html @@ -106,6 +106,7 @@

+
diff --git a/static/js/dark-init.js b/static/js/dark-init.js index e7b3f1d38e..d85627eea4 100644 --- a/static/js/dark-init.js +++ b/static/js/dark-init.js @@ -5,10 +5,6 @@ // This script is run blocking at the beginning of the page load to ensure that // we don't have flashing white background before switching to dark mode. (function () { - if (!document.body.classList.contains('-experimental-dark-mode')) { - return; - } - // Detects OS or browser-level theme preference by using media queries. let mediaPrefersDarkScheme = false; try {