diff --git a/app/lib/frontend/handlers/experimental.dart b/app/lib/frontend/handlers/experimental.dart index f42da4d181..e85424c1de 100644 --- a/app/lib/frontend/handlers/experimental.dart +++ b/app/lib/frontend/handlers/experimental.dart @@ -9,13 +9,7 @@ import '../../shared/cookie_utils.dart'; typedef PublicFlag = ({String name, String description}); const _publicFlags = { - (name: 'dark', description: 'Dark mode'), - (name: 'search-completion', description: 'Completions for the search bar'), (name: 'search-topics', description: 'Show matching topics when searching'), - ( - name: 'download-counts-version-chart', - description: 'Show downloads counts version chart' - ), }; final _allFlags = { @@ -92,14 +86,10 @@ class ExperimentalFlags { return params; } - bool get isSearchCompletionEnabled => true; bool get isSearchTopicsEnabled => isEnabled('search-topics'); - bool get isDarkModeEnabled => true; bool get isDarkModeDefault => isEnabled('dark-as-default'); - bool get showDownloadCountsVersionChart => true; - String encodedAsCookie() => _enabled.join(':'); @override diff --git a/app/lib/frontend/templates/views/pkg/package_list.dart b/app/lib/frontend/templates/views/pkg/package_list.dart index 31aca6d73a..5063932a54 100644 --- a/app/lib/frontend/templates/views/pkg/package_list.dart +++ b/app/lib/frontend/templates/views/pkg/package_list.dart @@ -225,7 +225,8 @@ d.Node _item({ classes: ['packages-header'], children: [ d.h3(classes: [ - 'packages-title' + 'packages-title', + 'pub-monochrome-icon-hoverable', ], children: [ d.a(href: url, text: name), if (copyIcon != null) copyIcon, diff --git a/app/lib/frontend/templates/views/pkg/score_tab.dart b/app/lib/frontend/templates/views/pkg/score_tab.dart index 9a61026d20..be621b7915 100644 --- a/app/lib/frontend/templates/views/pkg/score_tab.dart +++ b/app/lib/frontend/templates/views/pkg/score_tab.dart @@ -14,7 +14,6 @@ import 'package:pub_dev/shared/utils.dart'; import '../../../../scorecard/models.dart' hide ReportStatus; import '../../../../shared/urls.dart' as urls; import '../../../dom/dom.dart' as d; -import '../../../request_context.dart'; import '../../../static_files.dart'; /// Renders the score page content. @@ -95,8 +94,7 @@ d.Node scoreTabNode({ d.text(' for details.'), ], ), - if (card.weeklyVersionDownloads != null && - requestContext.experimentalFlags.showDownloadCountsVersionChart) + if (card.weeklyVersionDownloads != null) _downloadsChart(card.weeklyVersionDownloads!), ]); } diff --git a/app/lib/frontend/templates/views/shared/detail/header.dart b/app/lib/frontend/templates/views/shared/detail/header.dart index 318fa4663a..631e34ebd6 100644 --- a/app/lib/frontend/templates/views/shared/detail/header.dart +++ b/app/lib/frontend/templates/views/shared/detail/header.dart @@ -111,7 +111,10 @@ d.Node detailHeaderNode({ d.div( classes: ['detail-header-content-block'], children: [ - d.h1(classes: ['title'], child: titleNode), + d.h1( + classes: ['title', 'pub-monochrome-icon-hoverable'], + child: titleNode, + ), d.div(classes: ['metadata'], child: metadataNode), if (tagsNode != null || likeCount != null) d.div( diff --git a/app/lib/frontend/templates/views/shared/search_banner.dart b/app/lib/frontend/templates/views/shared/search_banner.dart index ef455c5de8..be6862ca4b 100644 --- a/app/lib/frontend/templates/views/shared/search_banner.dart +++ b/app/lib/frontend/templates/views/shared/search_banner.dart @@ -5,7 +5,6 @@ import 'dart:convert'; import 'package:_pub_shared/data/completion.dart'; -import 'package:pub_dev/frontend/request_context.dart'; import '../../../dom/dom.dart' as d; import '../../../static_files.dart' show staticUrls; @@ -36,8 +35,7 @@ d.Node searchBannerNode({ value: queryText, attributes: { 'title': 'Search', - if (requestContext.experimentalFlags.isSearchCompletionEnabled) - 'data-widget': 'completion', + 'data-widget': 'completion', 'data-completion-src': '/api/search-input-completion-data', 'data-completion-class': 'search-completion', }, diff --git a/app/lib/frontend/templates/views/shared/site_header.dart b/app/lib/frontend/templates/views/shared/site_header.dart index c5b8ffa8bf..cbb421ebaf 100644 --- a/app/lib/frontend/templates/views/shared/site_header.dart +++ b/app/lib/frontend/templates/views/shared/site_header.dart @@ -2,8 +2,6 @@ // for details. All rights reserved. Use of this source code is governed by a // BSD-style license that can be found in the LICENSE file. -import 'package:pub_dev/frontend/request_context.dart'; - import '../../../../account/models.dart' show SessionData; import '../../../../shared/urls.dart' as urls; import '../../../dom/dom.dart' as d; @@ -116,24 +114,17 @@ d.Node siteHeaderNode({ _userBlock(userSession), ], ), - _themeSwitcher(), + // TODO: consider using Material symbols similar to dartdoc: + // dark_mode + // light_mode + d.button( + classes: ['-pub-theme-toggle'], + ariaLabel: 'light/dark theme toggle', + ), ], ); } -d.Node _themeSwitcher() { - // dark_mode - // light_mode - if (requestContext.experimentalFlags.isDarkModeEnabled) { - return d.fragment([ - d.button( - classes: ['-pub-theme-toggle'], ariaLabel: 'light/dark theme toggle'), - ]); - } else { - return d.fragment([]); - } -} - d.Node _userBlock(SessionData userSession) { return d.div( classes: ['nav-container', 'nav-profile-container', 'hoverable'], diff --git a/app/test/frontend/golden/my_activity_log_page.html b/app/test/frontend/golden/my_activity_log_page.html index c9b03646de..60dd3598c9 100644 --- a/app/test/frontend/golden/my_activity_log_page.html +++ b/app/test/frontend/golden/my_activity_log_page.html @@ -142,7 +142,7 @@

user profile picture
-

admin

+

admin

-

user

+

user

-

user

+

user