From e4ccfbce833f3a220fa279a7a5d1511c64b2f193 Mon Sep 17 00:00:00 2001
From: Sarah Zakarias <zarah@google.com>
Date: Wed, 19 Feb 2025 12:34:13 +0000
Subject: [PATCH] Downloads chart: fix placement of cursor

---
 pkg/web_app/lib/src/widget/downloads_chart/widget.dart | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/pkg/web_app/lib/src/widget/downloads_chart/widget.dart b/pkg/web_app/lib/src/widget/downloads_chart/widget.dart
index 1db34f3586..77cbf2b0bc 100644
--- a/pkg/web_app/lib/src/widget/downloads_chart/widget.dart
+++ b/pkg/web_app/lib/src/widget/downloads_chart/widget.dart
@@ -232,7 +232,7 @@ void drawChart(
   }
 
   final chart = SVGGElement();
-  svg.replaceChildren(chart);
+  svg.append(chart);
 
   // Axis and ticks
 
@@ -449,7 +449,7 @@ void drawChart(
   hideCursor(1);
 
   svg.onMouseMove.listen((e) {
-    final boundingRect = chart.getBoundingClientRect();
+    final boundingRect = svg.getBoundingClientRect();
     if (e.x < boundingRect.x + xZero ||
         e.x > boundingRect.x + xMax ||
         e.y < boundingRect.y + yMax ||
@@ -465,10 +465,8 @@ void drawChart(
         'top:${e.y + toolTipOffsetFromMouse + document.scrollingElement!.scrollTop}px;'
             'left:${e.x}px;');
 
-    final pointPercentage =
-        (e.x - chart.getBoundingClientRect().x - xZero) / chartWidth;
+    final pointPercentage = (e.x - boundingRect.x - xZero) / chartWidth;
     final nearestIndex = ((values.length - 1) * pointPercentage).round();
-
     final selectedDay =
         computeDateForWeekNumber(newestDate, values.length, nearestIndex);
     if (selectedDay == lastSelectedDay) return;
@@ -497,7 +495,7 @@ void drawChart(
           ..append(rangeText);
 
         final suffix = (displayMode == DisplayMode.percentage)
-            ? '(${(downloads[rangeIndex] * 100 / totals[nearestIndex]).toStringAsPrecision(2)}%)'
+            ? ' (${(downloads[rangeIndex] * 100 / totals[nearestIndex]).toStringAsPrecision(2)}%)'
             : '';
         final text =
             '${formatWithThousandSeperators(downloads[rangeIndex])}$suffix';