Skip to content

Migrate some of pkg/web_app to package:web. #8577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2025
Merged

Migrate some of pkg/web_app to package:web. #8577

merged 1 commit into from
Feb 25, 2025

Conversation

@isoos
Copy link
Collaborator

@isoos isoos commented Feb 19, 2025

  • created toElementList<E>() helper for easier type casts
  • created animationFrame helper, as package:web doesn't support it as event
  • migrated the uses of dataset, which was really surprising, see more in Return String should be nullable, no? web#309

@isoos isoos requested review from jonasfj and sigurdm February 19, 2025 17:49
@isoos isoos merged commit 2da3718 into dart-lang:master Feb 25, 2025
31 checks passed
@isoos isoos deleted the migrate-web branch February 25, 2025 10:17
isoos added a commit to isoos/pub-dev that referenced this pull request Mar 5, 2025
@isoos
Migrate some of pkg/web_app to package:web. (dart-lang#8577)
9896d53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonasfj jonasfj jonasfj approved these changes

@sigurdm sigurdm Awaiting requested review from sigurdm

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@isoos @jonasfj