Downloads chart: Add helper function for computing closest point on line #8584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigurdm
approved these changes
Feb 25, 2025
| if (t < 0 || t > 1) { | ||
| // Closest point is before or after the line. This should not happen in | ||
| // our use case. | ||
| return (double.maxFinite, double.maxFinite); |
Contributor
There was a problem hiding this comment.
If it should not happen perhaps it is better to throw?
Contributor
Author
There was a problem hiding this comment.
It's not mathematically invalid, just not relevant in our use case. I updated the documentation a bit.
Contributor
There was a problem hiding this comment.
But isn't (double.maxFinite, double.maxFinite) the wrong answer in that case?
| return (ranges: ranges, weekLists: result.reversed.toList()); | ||
| } | ||
|
|
||
| /// Calculates closest point from [point] to line defined by [startPoint] and |
Contributor
There was a problem hiding this comment.
Is this more precise?
Suggested change
| /// Calculates closest point from [point] to line defined by [startPoint] and | |
| /// Calculates closest point to [point] on the line segment between[startPoint] and |
Contributor
Author
There was a problem hiding this comment.
I updated the comment a to something more similiar.
jonasfj
approved these changes
Feb 25, 2025
isoos
pushed a commit
to isoos/pub-dev
that referenced
this pull request
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.