From 50897e2281210f18280d34673de456bd5f6f655d Mon Sep 17 00:00:00 2001 From: Sarah Zakarias Date: Tue, 14 Oct 2025 12:09:45 +0000 Subject: [PATCH 1/2] Set '_regenerateGoldens' flag to false --- app/test/task/end2end_test.dart | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/app/test/task/end2end_test.dart b/app/test/task/end2end_test.dart index 1c9d4f447..ea0f35aa5 100644 --- a/app/test/task/end2end_test.dart +++ b/app/test/task/end2end_test.dart @@ -19,7 +19,7 @@ import '../shared/utils.dart'; const String goldenDir = 'test/task/testdata/goldens'; // TODO: generalize golden testing, use env var for regenerating all goldens. -final _regenerateGoldens = true; +final _regenerateGoldens = false; // We use a small test profile without flutter packages, because we have to // run pana+dartdoc for all these package versions, naturally this is slow. @@ -55,9 +55,7 @@ void main() { expect(doc.querySelector('.self-crumb')!.text, contains('oxygen')); // Check that we don't have noindex on /latest/ expect( - doc - .querySelectorAll('meta') - .where( + doc.querySelectorAll('meta').where( (m) => m.attributes['name'] == 'robots' && m.attributes['content'] == 'noindex', @@ -133,8 +131,8 @@ Future _traverseLinksUnderPath({ final r = relativeTo.resolveUri(u); return r.path; }; - final isUnderRoots = (String path) => - roots.any((root) => path.startsWith(root)); + final isUnderRoots = + (String path) => roots.any((root) => path.startsWith(root)); final visited = {}; // HTML pages to visit @@ -152,7 +150,8 @@ Future _traverseLinksUnderPath({ final res = await issueGet(target.toString(), headers: _headers); if (res.statusCode == 303) { htmlQueue.addAll( - [normalize(res.headers['location']!, target)].nonNulls + [normalize(res.headers['location']!, target)] + .nonNulls .whereNot(visited.contains) .whereNot(htmlQueue.contains) .whereNot(assetQueue.contains), From 56011b9d4425afa41b4d0c45cc170f53b9f24263 Mon Sep 17 00:00:00 2001 From: Sarah Zakarias Date: Tue, 14 Oct 2025 12:22:11 +0000 Subject: [PATCH 2/2] format --- app/test/task/end2end_test.dart | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/app/test/task/end2end_test.dart b/app/test/task/end2end_test.dart index ea0f35aa5..e89fe6400 100644 --- a/app/test/task/end2end_test.dart +++ b/app/test/task/end2end_test.dart @@ -55,7 +55,9 @@ void main() { expect(doc.querySelector('.self-crumb')!.text, contains('oxygen')); // Check that we don't have noindex on /latest/ expect( - doc.querySelectorAll('meta').where( + doc + .querySelectorAll('meta') + .where( (m) => m.attributes['name'] == 'robots' && m.attributes['content'] == 'noindex', @@ -131,8 +133,8 @@ Future _traverseLinksUnderPath({ final r = relativeTo.resolveUri(u); return r.path; }; - final isUnderRoots = - (String path) => roots.any((root) => path.startsWith(root)); + final isUnderRoots = (String path) => + roots.any((root) => path.startsWith(root)); final visited = {}; // HTML pages to visit @@ -150,8 +152,7 @@ Future _traverseLinksUnderPath({ final res = await issueGet(target.toString(), headers: _headers); if (res.statusCode == 303) { htmlQueue.addAll( - [normalize(res.headers['location']!, target)] - .nonNulls + [normalize(res.headers['location']!, target)].nonNulls .whereNot(visited.contains) .whereNot(htmlQueue.contains) .whereNot(assetQueue.contains),