Skip to content

Conversation

@isoos
Copy link
Collaborator

@isoos isoos commented Nov 18, 2025

No description provided.

@isoos isoos requested a review from jonasfj November 18, 2025 13:24
Copy link
Member

@jonasfj jonasfj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this largely makes sense, and the idea is that we'll primarily test calculateScanPackagesUpdatedLoop, right?


final DateTime since;

final DateTime nextLongScan;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd need a better name than nextLongScan, what is a "long scan"?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renamed to nextLongOverlap + added some description

@isoos
Copy link
Collaborator Author

isoos commented Nov 18, 2025

I think this largely makes sense, and the idea is that we'll primarily test calculateScanPackagesUpdatedLoop, right?

Yes, I've added some tests.

@isoos isoos marked this pull request as ready for review November 18, 2025 16:16
@isoos
Copy link
Collaborator Author

isoos commented Nov 18, 2025

I think we should also test the loop's logic, e.g. to execute the correct query for scanning and also to execute the task updates. But it is not yet clear to me how that should look like, and until that is figured out, we can start with the internals of the loops.

@isoos isoos merged commit 605e2d6 into dart-lang:master Nov 27, 2025
24 checks passed
@isoos isoos deleted the task-scanupdated branch November 27, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants