Skip to content

Refactor: scope exit registration near its component registration. #9094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2025
Merged

Refactor: scope exit registration near its component registration. #9094

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions app/lib/service/services.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,9 +266,13 @@ Future<R> _withPubServices<R>(FutureOr<R> Function() fn) async {
rethrow;
}
}

await setupCache();

registerAccountBackend(AccountBackend(dbService));
registerAdminBackend(AdminBackend(dbService));
registerAnnouncementBackend(AnnouncementBackend());
registerScopeExitCallback(announcementBackend.close);
registerApiExporter(
ApiExporter(
dbService,
Expand All @@ -279,15 +283,19 @@ Future<R> _withPubServices<R>(FutureOr<R> Function() fn) async {
),
);
registerAsyncQueue(AsyncQueue());
registerScopeExitCallback(asyncQueue.close);

registerAuditBackend(AuditBackend(dbService));
registerConsentBackend(ConsentBackend(dbService));
registerEmailBackend(EmailBackend(dbService));
registerLikeBackend(LikeBackend(dbService));
registerNameTracker(NameTracker(dbService));
registerScopeExitCallback(() async => nameTracker.stopTracking());
registerPackageIndexHolder(PackageIndexHolder());
registerIndexUpdater(IndexUpdater(dbService));
registerPublisherBackend(PublisherBackend(dbService));
registerScoreCardBackend(ScoreCardBackend(dbService));
registerScopeExitCallback(scoreCardBackend.close);
registerSearchBackend(
SearchBackend(
dbService,
Expand All @@ -296,7 +304,9 @@ Future<R> _withPubServices<R>(FutureOr<R> Function() fn) async {
),
),
);
registerScopeExitCallback(searchBackend.close);
registerSearchClient(SearchClient());
registerScopeExitCallback(searchClient.close);
registerSearchAdapter(SearchAdapter());

registerImageStorage(
Expand All @@ -305,7 +315,9 @@ Future<R> _withPubServices<R>(FutureOr<R> Function() fn) async {
),
);
registerTopPackages(TopPackages());
registerScopeExitCallback(topPackages.close);
registerYoutubeBackend(YoutubeBackend());
registerScopeExitCallback(youtubeBackend.close);

// depends on previously registered services
registerPackageBackend(
Expand All @@ -329,21 +341,10 @@ Future<R> _withPubServices<R>(FutureOr<R> Function() fn) async {
storageService.bucket(activeConfiguration.taskResultBucketName!),
),
);
registerScopeExitCallback(taskBackend.stop);
registerSecurityAdvisoryBackend(SecurityAdvisoryBackend(dbService));
registerDownloadCountsBackend(DownloadCountsBackend(dbService));

await setupCache();

registerScopeExitCallback(taskBackend.stop);
registerScopeExitCallback(announcementBackend.close);
registerScopeExitCallback(searchBackend.close);
registerScopeExitCallback(() async => nameTracker.stopTracking());
registerScopeExitCallback(scoreCardBackend.close);
registerScopeExitCallback(searchClient.close);
registerScopeExitCallback(topPackages.close);
registerScopeExitCallback(youtubeBackend.close);
registerScopeExitCallback(downloadCountsBackend.close);
registerScopeExitCallback(asyncQueue.close);

// Create a zone-local flag to indicate that services setup has been completed.
return await fork(
Expand Down