Skip to content

Commit

Permalink
Spelling fixes e to i.
Browse files Browse the repository at this point in the history
R=kevmoo@google.com
BUG=

Review-Url: https://codereview.chromium.org/2957593002 .
  • Loading branch information
ErikCorryGoogle committed Jun 24, 2017
1 parent b683e47 commit 029b1cb
Show file tree
Hide file tree
Showing 164 changed files with 217 additions and 214 deletions.
2 changes: 1 addition & 1 deletion build/config/compiler/BUILD.gn
Expand Up @@ -164,7 +164,7 @@ config("compiler") {
ldflags += common_mac_flags
} else if (is_posix) {
# CPU architecture. We may or may not be doing a cross compile now, so for
# simplicity we always explicitly set the architecture.
# simplicitly we always explicitly set the architecture.
if (current_cpu == "x64") {
cflags += [
"-m64",
Expand Down
Expand Up @@ -269,7 +269,7 @@ abstract class CommonInputConverter extends Converter<String, Operation> {
/**
* [InputConverter] converts an input stream
* into a series of operations to be sent to the analysis server.
* The input stream can be either an instrumenation or log file.
* The input stream can be either an instrumentation or log file.
*/
class InputConverter extends Converter<String, Operation> {
final Logger logger = new Logger('InputConverter');
Expand Down
Expand Up @@ -2054,7 +2054,7 @@ int myFunc() {}
}

test_FieldFormalParameter_in_non_constructor() async {
// SimpleIdentifer FieldFormalParameter FormalParameterList
// SimpleIdentifier FieldFormalParameter FormalParameterList
addTestSource('class A {B(this.^foo) {}}');
await computeSuggestions();
expect(replacementOffset, completionOffset);
Expand Down
Expand Up @@ -1882,7 +1882,7 @@ class C {foo(){^} void bar() {}}''');
}

test_FieldFormalParameter_in_non_constructor() async {
// SimpleIdentifer FieldFormalParameter FormalParameterList
// SimpleIdentifier FieldFormalParameter FormalParameterList
addTestSource('class A {B(this.^foo) {}}');
await computeSuggestions();

Expand Down
Expand Up @@ -2370,7 +2370,7 @@ class C {foo(){^} void bar() {}}''');
}

test_FieldFormalParameter_in_non_constructor() async {
// SimpleIdentifer FieldFormalParameter FormalParameterList
// SimpleIdentifier FieldFormalParameter FormalParameterList
addTestSource('class A {B(this.^foo) {}}');
await computeSuggestions();

Expand Down
Expand Up @@ -1891,7 +1891,7 @@ void main() {new A().f^}''');
}

test_FieldFormalParameter_in_non_constructor() async {
// SimpleIdentifer FieldFormalParameter FormalParameterList
// SimpleIdentifier FieldFormalParameter FormalParameterList
addTestSource('class A {B(this.^foo) {}}');
await computeSuggestions();
expect(replacementOffset, completionOffset);
Expand Down
2 changes: 1 addition & 1 deletion pkg/analyzer/lib/dart/ast/ast.dart
Expand Up @@ -4964,7 +4964,7 @@ abstract class MethodInvocation extends InvocationExpression {
}

/**
* An expression that implicity makes reference to a method.
* An expression that implicitly makes reference to a method.
*
* Clients may not extend, implement or mix-in this class.
*/
Expand Down
2 changes: 1 addition & 1 deletion pkg/analyzer/lib/plugin/options.dart
Expand Up @@ -12,7 +12,7 @@ import 'package:yaml/yaml.dart';
/// Validates options as defined in an analysis options file.
///
/// The options file format is intentionally very open-ended, giving clients
/// utmost flexibility in defining their own options. The only hardfast
/// utmost flexibility in defining their own options. The only hard and fast
/// expectation is that options files will contain a mapping from Strings
/// (identifying 'scopes') to associated options. For example, the given
/// content
Expand Down
2 changes: 1 addition & 1 deletion pkg/analyzer/lib/src/dart/element/type.dart
Expand Up @@ -2151,7 +2151,7 @@ class InterfaceTypeImpl extends TypeImpl implements InterfaceType {
_computeSuperinterfaceSet(type, new HashSet<InterfaceType>());

/**
* Return the type from the [types] list that has the longest inheritence path
* Return the type from the [types] list that has the longest inheritance path
* to Object of unique length.
*/
static InterfaceType computeTypeAtMaxUniqueDepth(List<InterfaceType> types) {
Expand Down
4 changes: 2 additions & 2 deletions pkg/analyzer/lib/src/dart/resolver/inheritance_manager.dart
Expand Up @@ -800,12 +800,12 @@ class InheritanceManager {
// we create a warning, and have this class inherit nothing.
//
if (!classHasMember) {
String firstTwoFuntionTypesStr =
String firstTwoFunctionTypesStr =
"${executableElementTypes[0]}, ${executableElementTypes[1]}";
_reportError(
classElt,
StaticTypeWarningCode.INCONSISTENT_METHOD_INHERITANCE,
[key, firstTwoFuntionTypesStr]);
[key, firstTwoFunctionTypesStr]);
}
} else {
//
Expand Down
2 changes: 1 addition & 1 deletion pkg/analyzer/lib/src/error/codes.dart
Expand Up @@ -2948,7 +2948,7 @@ class StaticTypeWarningCode extends ErrorCode {
"The function '{0}' isn't defined.",
"Try importing the library that defines '{0}', "
"correcting the name to the name of an existing function, or "
"defining a funtion named '{0}'.");
"defining a function named '{0}'.");

/**
* 12.17 Getter Invocation: Let <i>T</i> be the static type of <i>e</i>. It is
Expand Down
2 changes: 1 addition & 1 deletion pkg/analyzer/lib/src/generated/element_resolver.dart
Expand Up @@ -2223,7 +2223,7 @@ class ElementResolver extends SimpleAstVisitor<Object> {
* invoked with the arguments. The [target] is the target of the invocation
* ('e'). The [targetType] is the type of the target. The [methodName] is th
* name of the method being invoked ('m'). [isConditional] indicates
* whether the invocatoin uses a '?.' operator.
* whether the invocation uses a '?.' operator.
*/
Element _resolveInvokedElementWithTarget(Expression target,
DartType targetType, SimpleIdentifier methodName, bool isConditional) {
Expand Down
2 changes: 1 addition & 1 deletion pkg/analyzer/lib/src/generated/resolver.dart
Expand Up @@ -1857,7 +1857,7 @@ class ConstantVerifier extends RecursiveAstVisitor<Object> {
Expression initializer = variableDeclaration.initializer;
if (initializer != null) {
// Ignore any errors produced during validation--if the constant
// can't be eavluated we'll just report a single error.
// can't be evaluated we'll just report a single error.
AnalysisErrorListener errorListener =
AnalysisErrorListener.NULL_LISTENER;
ErrorReporter subErrorReporter =
Expand Down
4 changes: 2 additions & 2 deletions pkg/analyzer/lib/src/summary/fasta/summary_builder.dart
Expand Up @@ -182,7 +182,7 @@ class ConstExpressionBuilder extends ExpressionListener {

// bit-masks to encode async modifiers as bits on an int.

/// Parser listener to build simplified AST expresions.
/// Parser listener to build simplified AST expressions.
///
/// The parser produces different trees depending on whether it is used for
/// constants or initializers, so subclasses specialize the logic accordingly.
Expand All @@ -197,7 +197,7 @@ abstract class ExpressionListener extends StackListener {
/// Whether this listener is used to build const expressions.
bool get forConst => false;

/// Whether to ignore the next reduction. Used to ignore nested expresions
/// Whether to ignore the next reduction. Used to ignore nested expressions
/// that are either invalid (in constants) or unnecessary (for initializers).
bool get ignore => _withinFunction > 0 || _withinCascades > 0;

Expand Down
2 changes: 1 addition & 1 deletion pkg/analyzer/lib/src/task/driver.dart
Expand Up @@ -229,7 +229,7 @@ class AnalysisDriver {
*/
bool performAnalysisTask() {
//
// TODO(brianwilkerson) This implementaiton does not allow us to prioritize
// TODO(brianwilkerson) This implementation does not allow us to prioritize
// work across contexts. What we need is a way for an external client to ask
// to have all priority files analyzed for each context, then ask for normal
// files to be analyzed. There are a couple of ways to do this.
Expand Down
2 changes: 1 addition & 1 deletion pkg/analyzer/test/generated/parser_test.dart
Expand Up @@ -4155,7 +4155,7 @@ main() {
parseExpression("f()++", [ParserErrorCode.UNEXPECTED_TOKEN]);
}

void test_unexpectedToken_returnInExpressionFuntionBody() {
void test_unexpectedToken_returnInExpressionFunctionBody() {
parseCompilationUnit(
"f() => return null;", [ParserErrorCode.UNEXPECTED_TOKEN]);
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/analyzer/test/src/task/strong/checker_test.dart
Expand Up @@ -349,7 +349,7 @@ test() {
''');
}

test_constantGenericTypeArg_explict() async {
test_constantGenericTypeArg_explicit() async {
// Regression test for https://github.com/dart-lang/sdk/issues/26141
await checkFile('''
abstract class Equality<R> {}
Expand Down
6 changes: 3 additions & 3 deletions pkg/compiler/README.md
Expand Up @@ -242,7 +242,7 @@ revisited
AI: change how we build the SDK to launch dart2js from here, most logic might
remain inside `lib/src/dart2js.dart` for testing purposes.

* `bin/resolver.dart`: an experiemntal binary we used to run the resolver and
* `bin/resolver.dart`: an experimental binary we used to run the resolver and
serializer. As we are moving to work on top of kernel this is deprecated and
should be deleted.

Expand All @@ -268,7 +268,7 @@ library during `pub-build` and `pub-serve`.
is another), and delete the legacy API.

**lib/src folder**: most of the compiler lives here, as very little of its
funtionality is publicly exposed.
functionality is publicly exposed.


* `lib/src/dart2js.dart`: the command-line script that runs dart2js. When
Expand Down Expand Up @@ -362,7 +362,7 @@ funtionality is publicly exposed.
expressions may be folded. Different implementations of the constant system
are used to target Dart or JavaScript.

* `lib/src/compile_time_constants.dart`: defines how constant expresions are
* `lib/src/compile_time_constants.dart`: defines how constant expressions are
created from a parsed AST.

* `lib/src/constant_system_dart.dart`: defines an implementation of a constant
Expand Down
2 changes: 1 addition & 1 deletion pkg/compiler/lib/src/closure.dart
Expand Up @@ -1072,7 +1072,7 @@ class ClosureTranslator extends Visitor {
// In checked mode, using a type variable in a type annotation may lead
// to a runtime type check that needs to access the type argument and
// therefore the closure needs a this-element, if it is not in a field
// initializer; field initatializers are evaluated in a context where
// initializer; field initializers are evaluated in a context where
// the type arguments are available in locals.
registerNeedsThis();
}
Expand Down
6 changes: 3 additions & 3 deletions pkg/compiler/lib/src/elements/elements.dart
Expand Up @@ -557,7 +557,7 @@ class Elements {
* For non-operator names, this method just returns its input.
*
* The results returned from this method are guaranteed to be valid
* JavaScript identifers, except it may include reserved words for
* JavaScript identifiers, except it may include reserved words for
* non-operator names.
*/
static String operatorNameToIdentifier(String name) {
Expand Down Expand Up @@ -1823,11 +1823,11 @@ abstract class MemberSignature {
/// parameters.
ResolutionFunctionType get functionType;

/// Returns `true` if this member is a getter, possibly implictly defined by a
/// Returns `true` if this member is a getter, possibly implicitly defined by a
/// field declaration.
bool get isGetter;

/// Returns `true` if this member is a setter, possibly implictly defined by a
/// Returns `true` if this member is a setter, possibly implicitly defined by a
/// field declaration.
bool get isSetter;

Expand Down
2 changes: 1 addition & 1 deletion pkg/compiler/lib/src/elements/resolution_types.dart
Expand Up @@ -96,7 +96,7 @@ abstract class ResolutionDartType implements DartType {
*/
ResolutionDartType get userProvidedBadType => null;

/// Is [: true :] if this type has no explict type arguments.
/// Is [: true :] if this type has no explicit type arguments.
bool get isRaw => true;

/// Returns the raw version of this type.
Expand Down
2 changes: 1 addition & 1 deletion pkg/compiler/lib/src/elements/types.dart
Expand Up @@ -18,7 +18,7 @@ import 'entities.dart';
///
/// Current only 'resolution_types.dart' implement this hierarchy but when the
/// compiler moves to use [Entity] instead of [Element] this hierarchy can be
/// implementated directly but other entity systems, for instance based directly
/// implemented directly but other entity systems, for instance based directly
/// on kernel ir without the need for [Element].
abstract class DartType {
Expand Down
2 changes: 1 addition & 1 deletion pkg/compiler/lib/src/helpers/helpers.dart
Expand Up @@ -40,7 +40,7 @@ _DebugIndentation _indentation = new _DebugIndentation();
/// Function signature of [debugPrint].
typedef DebugPrint(s);

/// If [DEBUG_PRINT_ENABLED] is `true` print [s] using the current identation.
/// If [DEBUG_PRINT_ENABLED] is `true` print [s] using the current indentation.
DebugPrint get debugPrint {
enableDebugMode();
// TODO(johnniwinther): Maybe disable debug mode after the call.
Expand Down
4 changes: 2 additions & 2 deletions pkg/compiler/lib/src/inferrer/type_graph_nodes.dart
Expand Up @@ -383,7 +383,7 @@ class MemberTypeInformation extends ElementTypeInformation

/**
* If [element] is a function, [closurizedCount] is the number of
* times it is closurized. The value gets updated while infering.
* times it is closurized. The value gets updated while inferring.
*/
int closurizedCount = 0;

Expand Down Expand Up @@ -456,7 +456,7 @@ class MemberTypeInformation extends ElementTypeInformation
// Closurized methods never become stable to ensure that the information in
// [users] is accurate. The inference stops tracking users for stable types.
// Note that we only override the getter, the setter will still modify the
// state of the [isStable] field inhertied from [TypeInformation].
// state of the [isStable] field inherited from [TypeInformation].
bool get isStable => super.isStable && !isClosurized;

TypeMask handleSpecialCases(InferrerEngine inferrer) {
Expand Down
Expand Up @@ -205,7 +205,7 @@ class CustomElementsAnalysisJoin {
escapingConstructors
.forEach(_backendUsageBuilder.registerGlobalFunctionDependency);
}
// Force the generaton of the type constant that is the key to an entry
// Force the generation of the type constant that is the key to an entry
// in the generated table.
ConstantValue constant = _makeTypeConstant(cls);
impactBuilder
Expand Down
2 changes: 1 addition & 1 deletion pkg/compiler/lib/src/js_backend/namer.dart
Expand Up @@ -1919,7 +1919,7 @@ class ConstantNamingVisitor implements ConstantValueVisitor {
if (name == 'index') {
indexField = field;
} else if (name == '_name') {
// Ingore _name field.
// Ignore _name field.
} else {
indexField = null;
break;
Expand Down
4 changes: 2 additions & 2 deletions pkg/compiler/lib/src/js_backend/runtime_types.dart
Expand Up @@ -108,7 +108,7 @@ abstract class RuntimeTypesSubstitutions {
Substitution getSubstitution(ClassEntity cls, ClassEntity other);

/// Compute the required type checks and substitutions for the given
/// instantitated and checked classes.
/// instantiated and checked classes.
TypeChecks computeChecks(
Set<ClassEntity> instantiated, Set<ClassEntity> checked);

Expand Down Expand Up @@ -944,7 +944,7 @@ class RuntimeTypesEncoderImpl implements RuntimeTypesEncoder {
// adding ground-term type parameters, as they would just be 'dynamic'.
// TODO(sra): Since the result string is used only in constructing constant
// names, it would result in more readable names if the final string was a
// legal JavaScript identifer.
// legal JavaScript identifier.
if (interface.typeArguments.isEmpty) return name;
String arguments =
new List.filled(interface.typeArguments.length, 'dynamic').join(', ');
Expand Down
2 changes: 1 addition & 1 deletion pkg/compiler/lib/src/js_emitter/class_stub_generator.dart
Expand Up @@ -87,7 +87,7 @@ class ClassStubGenerator {
Map<jsAst.Name, jsAst.Expression> generateCallStubsForGetter(
MemberEntity member, Map<Selector, SelectorConstraints> selectors) {
// If the method is intercepted, the stub gets the
// receiver explicitely and we need to pass it to the getter call.
// receiver explicitly and we need to pass it to the getter call.
bool isInterceptedMethod = _interceptorData.isInterceptedMethod(member);
bool isInterceptedClass =
_interceptorData.isInterceptedClass(member.enclosingClass);
Expand Down
2 changes: 1 addition & 1 deletion pkg/compiler/lib/src/js_emitter/native_generator.dart
Expand Up @@ -19,7 +19,7 @@ class NativeGenerator {

/// Generates the code for isolate affinity tags.
///
/// Independently Dart programs on the same page must not interfer and
/// Independently Dart programs on the same page must not interfere and
/// this code sets up the variables needed to guarantee that behavior.
static jsAst.Statement generateIsolateAffinityTagInitialization(
BackendUsage backendUsage,
Expand Down
Expand Up @@ -298,7 +298,7 @@ class RuntimeTypeGenerator {
if (call != null && call.isFunction) {
FunctionElement callFunction = call;
// A superclass might already implement the Function interface. In such
// a case, we can avoid emiting the is test here.
// a case, we can avoid emitting the is test here.
if (!cls.superclass.implementsFunction(_commonElements)) {
_generateInterfacesIsTests(_commonElements.functionClass,
generateIsTest, generateSubstitution, generated);
Expand Down
2 changes: 1 addition & 1 deletion pkg/compiler/lib/src/js_emitter/type_test_registry.dart
Expand Up @@ -34,7 +34,7 @@ class TypeTestRegistry {
Set<ClassEntity> checkedClasses;

/**
* The set of function types that checked, both explicity through tests of
* The set of function types that checked, both explicitly through tests of
* typedefs and implicitly through type annotations in checked mode.
*/
Set<FunctionType> checkedFunctionTypes;
Expand Down
2 changes: 1 addition & 1 deletion pkg/compiler/lib/src/native/behavior.dart
Expand Up @@ -907,7 +907,7 @@ abstract class BehaviorBuilder {
return types;
}

/// Models the behavior of having intances of [type] escape from Dart code
/// Models the behavior of having instances of [type] escape from Dart code
/// into native code.
void _escape(DartType type) {
if (type is ResolutionDartType) {
Expand Down
Expand Up @@ -389,7 +389,7 @@ class ResolvedAstDeserializer {
int charOffset = objectDecoder.getInt(Key.OFFSET);
Token beginToken = getBeginToken(uri, charOffset);
if (beginToken == null) {
// TODO(johnniwinther): Handle unfound tokens by adding an erronous
// TODO(johnniwinther): Handle unfound tokens by adding an erroneous
// resolved ast kind.
reporter.internalError(
element, "No token found for $element in $uri @ $charOffset");
Expand Down
4 changes: 2 additions & 2 deletions pkg/compiler/lib/src/serialization/values.dart
Expand Up @@ -2,7 +2,7 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

/// Class hiarchy for semantic wrapping of serializable values.
/// Class hierarchy for semantic wrapping of serializable values.
library dart2js.serialization.values;

Expand Down Expand Up @@ -32,7 +32,7 @@ import 'keys.dart';
/// The distinction between map and object values is chosen to provide a more
/// robust and checkable implementation of the latter; since the keys are drawn
/// from a fixed typed set of values, consistency between serialization and
/// deserialization is easierly maintained.
/// deserialization is more easily maintained.
abstract class Value {
accept(ValueVisitor visitor, arg);
}
Expand Down
4 changes: 2 additions & 2 deletions pkg/compiler/lib/src/ssa/builder.dart
Expand Up @@ -6229,7 +6229,7 @@ class SsaAstGraphBuilder extends ast.Visitor
endFinallyBlock.addSuccessor(exitBlock);

// If a block inside try/catch aborts (eg with a return statement),
// we explicitely mark this block a predecessor of the catch
// we explicitly mark this block a predecessor of the catch
// block and the finally block.
addExitTrySuccessor(startFinallyBlock);

Expand Down Expand Up @@ -6437,7 +6437,7 @@ class SsaAstGraphBuilder extends ast.Visitor
}

// If a block inside try/catch aborts (eg with a return statement),
// we explicitely mark this block a predecessor of the catch
// we explicitly mark this block a predecessor of the catch
// block and the finally block.
addExitTrySuccessor(startCatchBlock);
addExitTrySuccessor(startFinallyBlock);
Expand Down

0 comments on commit 029b1cb

Please sign in to comment.