From 16e607ede5a56a5bb50337cc089c1c61ff660f9a Mon Sep 17 00:00:00 2001 From: Anna Gringauze Date: Fri, 10 Jul 2020 16:56:37 +0000 Subject: [PATCH] Set --debugger-module-names to true by default in preparation for removal of the flag first step for resolving https://github.com/dart-lang/sdk/issues/42104 Change-Id: Ie385e1d014149d67c5223aef698132b67df7ee43 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153949 Reviewed-by: Jonah Williams Reviewed-by: Sigmund Cherem Commit-Queue: Anna Gringauze --- pkg/frontend_server/lib/frontend_server.dart | 2 +- pkg/frontend_server/test/frontend_server_test.dart | 4 ---- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/pkg/frontend_server/lib/frontend_server.dart b/pkg/frontend_server/lib/frontend_server.dart index 8d5fcf4bd078..df6d860ce16b 100644 --- a/pkg/frontend_server/lib/frontend_server.dart +++ b/pkg/frontend_server/lib/frontend_server.dart @@ -175,7 +175,7 @@ ArgParser argParser = ArgParser(allowTrailingOptions: true) ..addOption('libraries-spec', help: 'A path or uri to the libraries specification JSON file') ..addFlag('debugger-module-names', - help: 'Use debugger-friendly modules names', defaultsTo: false) + help: 'Use debugger-friendly modules names', defaultsTo: true) ..addFlag('experimental-emit-debug-metadata', help: 'Emit module and library metadata for the debugger', defaultsTo: false) diff --git a/pkg/frontend_server/test/frontend_server_test.dart b/pkg/frontend_server/test/frontend_server_test.dart index a042a1e2834e..d4b17b79667a 100644 --- a/pkg/frontend_server/test/frontend_server_test.dart +++ b/pkg/frontend_server/test/frontend_server_test.dart @@ -1490,7 +1490,6 @@ true '--output-dill=${dillFile.path}', '--target=dartdevc', '--packages=${tempDir.path}/.packages', - '--debugger-module-names' ]; final StreamController> streamController = @@ -1557,7 +1556,6 @@ true '--output-dill=${dillFile.path}', '--target=dartdevc', '--packages=${tempDir.path}/.packages', - '--debugger-module-names', '--experimental-emit-debug-metadata' ]; @@ -1621,7 +1619,6 @@ true '--output-dill=${dillFile.path}', '--target=dartdevc', '--packages=${tempDir.path}/.packages', - '--debugger-module-names' ]; final StreamController> streamController = @@ -1729,7 +1726,6 @@ true '--output-dill=${dillFile.path}', '--target=dartdevc', '--packages=${tempDir.path}/.packages', - '--debugger-module-names' ]; final StreamController> streamController =