Skip to content
Permalink
Branch: master
Commits on Jul 17, 2019
  1. Better check for TextStyle opt-in for nested properties.

    scheglov committed Jul 17, 2019
    Not a huge different, just closer to what we might want in the future.
    I decided to make it explicit opt-in for now, until we kow better.
    
    R=brianwilkerson@google.com
    
    Change-Id: Ied8defe87bfd8b35117af085389cbab7e9b7d589
    Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109315
    Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
  2. [VM/runtime] Enable FLAG_unopt_megamorphic_calls by default, this fixes

    a-siva authored and commit-bot@chromium.org committed Jul 17, 2019
                 the recent regression seen in flutter hot reload benchmarks
    	     after the roll of Dart BE into flutter post 1.7 release.
    
    Change-Id: I188fa4aafdd7cdfa6b793de9d7ab00c9dae05409
    Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109361
    Reviewed-by: Ryan Macnak <rmacnak@google.com>
    Commit-Queue: Siva Annamalai <asiva@google.com>
Commits on Jul 16, 2019
  1. Revert "[vm/compiler] Use pragmas instead of separately-maintained li…

    a-siva authored and commit-bot@chromium.org committed Jul 16, 2019
    …sts for inlining."
    
    This reverts commit 33a7572.
    
    Reason for revert: This CL seems to depend on
    @pragma('vm:never-inline')`
    @pragma('vm:prefer-inline')`
    being implemented which has been reverted.
    
    Original change's description:
    > [vm/compiler] Use pragmas instead of separately-maintained lists for inlining.
    > 
    > This closes #36571.
    > 
    > Change-Id: I4d77192f2c33dd4872d58ef07ccd32069b8b63df
    > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99154
    > Commit-Queue: Teagan Strickland <sstrickl@google.com>
    > Reviewed-by: Martin Kustermann <kustermann@google.com>
    
    TBR=kustermann@google.com,sstrickl@google.com
    
    Change-Id: Ied0686ad282f2ed772ff9adbc551f64ba8855aff
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109340
    Reviewed-by: Siva Annamalai <asiva@google.com>
    Commit-Queue: Siva Annamalai <asiva@google.com>
  2. Revert "[vm/compiler] Implement new inlining pragmas."

    a-siva authored and commit-bot@chromium.org committed Jul 16, 2019
    This reverts commit 629f38c.
    
    Reason for revert: This CL seems to depend on constant_update_2018 flag being turned on by default. The CL that turns on constant_update_2018 has been reverted, so this CL is also being reverted.
    
    Original change's description:
    > [vm/compiler] Implement new inlining pragmas.
    > 
    > This change introduces two new pragmas:
    > 
    > * `@pragma('vm:never-inline')`
    > * `@pragma('vm:prefer-inline')`
    > 
    > These replaces the old way of specifying AlwaysInline or NeverInline
    > annotations when the (now removed) --enable-inlining-annotations flag
    > was used.
    > 
    > Bug: #36571
    > Change-Id: I2495c72819d94e43cefc837d4eb454b7b3d4140c
    > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99148
    > Commit-Queue: Teagan Strickland <sstrickl@google.com>
    > Reviewed-by: Samir Jindel <sjindel@google.com>
    
    TBR=sjindel@google.com,sstrickl@google.com
    
    Change-Id: Idc8e8344adb026a308af20c8b0d0224edb891d9c
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: #36571
    Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109320
    Reviewed-by: Siva Annamalai <asiva@google.com>
    Commit-Queue: Siva Annamalai <asiva@google.com>
  3. Revert "[dart] Enable constant-update-2018"

    a-siva committed Jul 16, 2019
    This reverts commit 9bbd319.
    
    Reason for revert: Reverting enabling of constant-update-2018 by default as some blocking issues were found that are breaking Flutter and preventing rolls of Dart into Flutter. Once the blocking issues are addressed and fixed this CL will be relanded.
    
    Original change's description:
    > [dart] Enable constant-update-2018
    > 
    > Change-Id: Ib3942b4f6e336a02826305d9f81839333a5464a0
    > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106943
    > Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
    > Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
    
    TBR=paulberry@google.com,vegorov@google.com,athom@google.com,vsm@google.com,aadilmaan@google.com
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Change-Id: I5796881412cec464f450ff3894ca253c58edc4a2
    Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109308
    Reviewed-by: Siva Annamalai <asiva@google.com>
    Reviewed-by: Vijay Menon <vsm@google.com>
  4. Resolve operators whose left operand is an extension override

    bwilkerson committed Jul 16, 2019
    Change-Id: I2731e5c95cd9c3c3e127124ad22d08a8695b1235
    Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109311
    Reviewed-by: Phil Quitslund <pquitslund@google.com>
    Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
  5. Implement getWidgetDescription and setPropertyValue in Flutter domain.

    scheglov committed Jul 16, 2019
    R=brianwilkerson@google.com
    
    Change-Id: I45fdb0121bdd067856e5c9e72466d9a5c1a00e55
    Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109313
    Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
  6. Fix resolution when there are multiple extensions in one unit

    bwilkerson committed Jul 16, 2019
    Change-Id: I8ef55ad7e74fc6a87d5d927aeea5a8a5566a7668
    Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109312
    Reviewed-by: Phil Quitslund <pquitslund@google.com>
    Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
  7. [dart2js] Support positional optional params in function RTI.

    fishythefish authored and commit-bot@chromium.org committed Jul 16, 2019
    Change-Id: Ieebe334706752b19fd65d0eb62460c98217ab887
    Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109201
    Reviewed-by: Stephen Adams <sra@google.com>
    Commit-Queue: Mayank Patke <fishythefish@google.com>
  8. [dart2js] Polyfill Object.assign()

    fishythefish authored and commit-bot@chromium.org committed Jul 16, 2019
    Change-Id: I4ae5172c2e39106be3609d5c6a569d176fdc0066
    Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107581
    Commit-Queue: Mayank Patke <fishythefish@google.com>
    Auto-Submit: Mayank Patke <fishythefish@google.com>
    Reviewed-by: Stephen Adams <sra@google.com>
  9. Add a diagnostic when extension overrides do not have exactly one arg…

    bwilkerson committed Jul 16, 2019
    …ument
    
    Change-Id: Id48e8bc04c37cd45d018d3f9ec656c4b2d7426a6
    Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109310
    Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
    Reviewed-by: Phil Quitslund <pquitslund@google.com>
  10. Extract PropertyDescription, support for nested properties.

    scheglov committed Jul 16, 2019
    R=brianwilkerson@google.com
    
    Change-Id: I3bf4938136120d640aaddc64854973714db33265
    Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109309
    Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
  11. [vm] initialize sigaction for msan

    ZichangG authored and commit-bot@chromium.org committed Jul 16, 2019
    msan didn't recognize instance initialized with memset or bzero. Initialize all the instances.
    
    Bug: https://buganizer.corp.google.com/issues/137630695
    Change-Id: I0f4adf90cd9d4daa2abe783b1e1ca892bdacb690
    Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109306
    Reviewed-by: Ryan Macnak <rmacnak@google.com>
    Commit-Queue: Zichang Guo <zichangguo@google.com>
  12. [vm/websocket] check status of streamcontroller before adding

    ZichangG authored and commit-bot@chromium.org committed Jul 16, 2019
    ping/pong mechenism will send reponse without checking whether stream controller is closed or not.
    
    Bug: #37441
    Change-Id: Iaaec052a6ad82f1bccf7a50a646867665c7e9e8e
    Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109304
    Reviewed-by: Siva Annamalai <asiva@google.com>
    Commit-Queue: Zichang Guo <zichangguo@google.com>
  13. Resolve extension overrides referencing a geter or setter

    bwilkerson committed Jul 16, 2019
    Change-Id: I694110e7420b5f7d6450639f0af61948b3511711
    Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109305
    Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
  14. Add an error if an undefined extension method is invoked

    bwilkerson committed Jul 16, 2019
    Change-Id: Ie21f2ab2ba12d8401cd82191020979b7c6dce244
    Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109301
    Reviewed-by: Phil Quitslund <pquitslund@google.com>
  15. [ VM / Service ] Handle case where a JSON RPC notification results in…

    bkonyi committed Jul 16, 2019
    … an error
    
    JSON RPC notifications never receive a response by design. In the VM
    service, if an error needs to be returned for a request and the request
    was a notification (i.e., has no ID associated with it), null is
    returned. The Dart side of the service tries to create a Response object
    with the null value, resulting in an exception being thrown. This change
    will swallow the errors in situations where a notification RPC is
    invalid.
    
    Change-Id: If7d889150bfec51b933474f7a66fffb25e82daed
    Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109200
    Reviewed-by: Siva Annamalai <asiva@google.com>
  16. Clean up the tests for extension overrides

    bwilkerson committed Jul 16, 2019
    Change-Id: I1e74b51220b08a48788a387b8c1c60ec60cc28fb
    Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109122
    Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
    Reviewed-by: Phil Quitslund <pquitslund@google.com>
  17. [dart2js] Test type directives

    johnniwinther authored and commit-bot@chromium.org committed Jul 16, 2019
    Change-Id: I4b0459bc097bb5618ab32f479a703ec35303436b
    Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109080
    Commit-Queue: Johnni Winther <johnniwinther@google.com>
    Reviewed-by: Stephen Adams <sra@google.com>
  18. [dart2js] More error tests on pragma annotations

    johnniwinther authored and commit-bot@chromium.org committed Jul 16, 2019
    Change-Id: Ic8d27d795f5511ef46d3c7e53a179f766529d0b3
    Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108814
    Reviewed-by: Stephen Adams <sra@google.com>
  19. [cfe+dart2js] Support library and error ids in annotated tests

    johnniwinther authored and commit-bot@chromium.org committed Jul 16, 2019
    Change-Id: Ife808a7d4aa1d4cf459ac3c04ee6ff02042442d9
    Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108810
    Reviewed-by: Stephen Adams <sra@google.com>
  20. improve applicable extension checking

    pq authored and commit-bot@chromium.org committed Jul 16, 2019
    Follow-up from https://dart-review.googlesource.com/c/sdk/+/109144.
    
    * guards against extension dups
    * improves checking to only tests types once (and migrates to using `TypeSystem.isSubtypeOf`)
    
    
    Change-Id: Ibb5791dc6a52374d751315385341071fee5dde1a
    Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109240
    Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
    Commit-Queue: Phil Quitslund <pquitslund@google.com>
  21. correlate typo

    pq authored and commit-bot@chromium.org committed Jul 16, 2019
    Change-Id: I800a122b574721457194eee5f47683d47cd92b81
    Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109241
    Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
    Commit-Queue: Phil Quitslund <pquitslund@google.com>
  22. [vm] Use absolute file path to snapshot in dart_precompiled_runtime2 …

    sjindel-google authored and commit-bot@chromium.org committed Jul 16, 2019
    …tool.
    
    Change-Id: I99d13aed0cb41c6b7e226bce3fd359c86e6f17a2
    Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108727
    Commit-Queue: Samir Jindel <sjindel@google.com>
    Auto-Submit: Samir Jindel <sjindel@google.com>
    Reviewed-by: Clement Skau <cskau@google.com>
  23. Add context messages for equal map keys and set elements

    bwilkerson authored and commit-bot@chromium.org committed Jul 16, 2019
    Change-Id: If1a2af91f35f869f7a9df89d0729949d5098c3b9
    Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109181
    Auto-Submit: Brian Wilkerson <brianwilkerson@google.com>
    Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
    Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
  24. [vm/compiler] Use pragmas instead of separately-maintained lists for …

    sstrickl authored and commit-bot@chromium.org committed Jul 16, 2019
    …inlining.
    
    This closes #36571.
    
    Change-Id: I4d77192f2c33dd4872d58ef07ccd32069b8b63df
    Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99154
    Commit-Queue: Teagan Strickland <sstrickl@google.com>
    Reviewed-by: Martin Kustermann <kustermann@google.com>
  25. [vm/compiler] Implement new inlining pragmas.

    sstrickl authored and commit-bot@chromium.org committed Jul 16, 2019
    This change introduces two new pragmas:
    
    * `@pragma('vm:never-inline')`
    * `@pragma('vm:prefer-inline')`
    
    These replaces the old way of specifying AlwaysInline or NeverInline
    annotations when the (now removed) --enable-inlining-annotations flag
    was used.
    
    Bug: #36571
    Change-Id: I2495c72819d94e43cefc837d4eb454b7b3d4140c
    Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99148
    Commit-Queue: Teagan Strickland <sstrickl@google.com>
    Reviewed-by: Samir Jindel <sjindel@google.com>
  26. Revert recent changes to File.openRead() and HttpClientResponse APIs

    tvolkert authored and commit-bot@chromium.org committed Jul 16, 2019
    This changes `File.openRead()` back to returning a `Stream<List<int>>`
    and `HttpClientResponse` back to implementing `Stream<List<int>>`.
    These two changes broke a significant number of call sites; backing it
    out enables us to keep the changes from landing in the next dev release
    until we analyze whether we can roll these changes out in a softer
    manner or if they're worth making at all.
    
    Bug: #36900
    Change-Id: I8977abcba40c58a4ca2b4a05d857512989a1e0b4
    Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109102
    Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
    Commit-Queue: Todd Volkert <tvolkert@google.com>
  27. [analyzer+cfe] Use more shared code for annotated code testing.

    johnniwinther authored and commit-bot@chromium.org committed Jul 16, 2019
    Change-Id: Id1d234beed0059c84375bbeefb4755fac23d72c6
    Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108817
    Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
    Commit-Queue: Johnni Winther <johnniwinther@google.com>
  28. [cfe] Remove KernelTypeBuilder and KernelFunctionTypeBuilder

    johnniwinther authored and commit-bot@chromium.org committed Jul 16, 2019
    TypeBuilder and FunctionTypeBuilder are only subclassed by
    KernelTypeBuilder and KernelFunctionTypeBuilder, respectively, so the
    distinction can be removed.
    
    Change-Id: I2cccd0d6b08f695ecb6ccb543f858edd4919cfda
    Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108819
    Reviewed-by: Dan Rubel <danrubel@google.com>
    Commit-Queue: Johnni Winther <johnniwinther@google.com>
  29. [vm] skip profile test for simdbc

    ZichangG authored and commit-bot@chromium.org committed Jul 16, 2019
    Bug: #36932
    Change-Id: I2062da67f5d679b65ac746f424f1bb1f5450834e
    Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109180
    Reviewed-by: Ben Konyi <bkonyi@google.com>
    Commit-Queue: Zichang Guo <zichangguo@google.com>
Commits on Jul 15, 2019
  1. extension method resolution

    pq authored and commit-bot@chromium.org committed Jul 15, 2019
    Change-Id: Id9e5fa618bc5ad284ab0415ccc0e515a475d095a
    Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109144
    Commit-Queue: Phil Quitslund <pquitslund@google.com>
    Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
  2. [vm, bytecode] Field initializer for schema changes.

    rmacnak-google authored and commit-bot@chromium.org committed Jul 15, 2019
    Bug: #32299
    Change-Id: Id6359ad36db183f4cdd091e7fd778c879e868d99
    Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108901
    Commit-Queue: Ryan Macnak <rmacnak@google.com>
    Reviewed-by: Alexander Markov <alexmarkov@google.com>
  3. [gardening] Move language_2/conditional_rewrite_test

    rakudrama authored and commit-bot@chromium.org committed Jul 15, 2019
    Change-Id: I878230e5ed311d5d51b15c48c9fb5dca447e0ef0
    Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108905
    Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
    Commit-Queue: Stephen Adams <sra@google.com>
  4. Initial implementation of extension override resolution

    bwilkerson authored and commit-bot@chromium.org committed Jul 15, 2019
    Change-Id: I3cb1de3f82a3995c015e8f3045cab4b3ac83a079
    Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109141
    Reviewed-by: Phil Quitslund <pquitslund@google.com>
    Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
    Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Older
You can’t perform that action at this time.