Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement tree-shaking based on MirrorsUsed

Closed
peter-ahe-google opened this issue Jun 26, 2013 · 15 comments
Closed

Implement tree-shaking based on MirrorsUsed #11524

peter-ahe-google opened this issue Jun 26, 2013 · 15 comments

Comments

@peter-ahe-google
Copy link
Contributor

peter-ahe-google commented Jun 26, 2013

dart2js needs to respect MirrorsUsed metadata in dart:mirrors.

@peter-ahe-google
Copy link
Contributor Author

peter-ahe-google commented Jun 28, 2013

Added Library-Mirrors label.

@justinfagnani
Copy link
Contributor

justinfagnani commented Jul 26, 2013

Removed Priority-Medium label.
Added Priority-High, C1 labels.

@peter-ahe-google
Copy link
Contributor Author

peter-ahe-google commented Jul 30, 2013

Issue #12125 has been merged into this issue.

@peter-ahe-google
Copy link
Contributor Author

peter-ahe-google commented Jul 30, 2013

@peter-ahe-google
Copy link
Contributor Author

peter-ahe-google commented Jul 30, 2013

Marked this as blocking #6490.

@peter-ahe-google
Copy link
Contributor Author

peter-ahe-google commented Aug 7, 2013

CL 21242002 landed in r25873.

@peter-ahe-google
Copy link
Contributor Author

peter-ahe-google commented Aug 7, 2013

https://codereview.chromium.org/22301009/ reduces the number of symbols stored in compiled output.

@peter-ahe-google
Copy link
Contributor Author

peter-ahe-google commented Aug 7, 2013

CL 22301009 landed in r25878.

@larsbak
Copy link

larsbak commented Aug 27, 2013

Added this to the M7 milestone.

@peter-ahe-google
Copy link
Contributor Author

peter-ahe-google commented Aug 27, 2013

I'm lowering the priority: MirrorsUsed is not fully implemented, but can be used to control tree-shaking.

The missing part is supporting metaTargets, which we don't deem a high priority at the moment.


Removed Priority-High label.
Added Priority-Medium label.

@kasperl
Copy link

kasperl commented Oct 2, 2013

Removed this from the M7 milestone.
Added this to the M8 milestone.

@kasperl
Copy link

kasperl commented Jun 4, 2014

Removed this from the M8 milestone.
Added this to the 1.6 milestone.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the 1.6 milestone.
Added Oldschool-Milestone-1.6 label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-1.6 label.

@matanlurey
Copy link
Contributor

matanlurey commented Mar 3, 2018

Mirrors is no longer supported in Dart2JS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants