Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Multiple imports with noscript tags, only contents of one are displayed (tags are correct however) #14274
This issue was originally filed by @butlermatt
Fork this repo:
Run noscript_bug.html and click on buttons. Content does not change, however notice console output does show correct tags.
Now remove the noscript attribute on one or more of the components (one_element, two_element and help_me). And uncomment the script lines. Run app again. Content is displayed as expected.
I have tried this with Polymer 0.8.4 and issue is the same (previous version was 0.8.2)
Also see discussion here:
This comment was originally written by @butlermatt
Opps to reiterate the title...
Multiple custom elements with noscript attribute are imported. While the tags update correctly the contents of the tag are no changing. That is one_element.html content displays but when I load two-element custom element the tags update but the content is still the same as one-element. Similar when updating with help-me element. However if I add an empty class and remove the noscript attribute, the contents displayed by the tags updates accordingly.
ah! thanks for the repro. I think I figured it out. Bug is here in instance.dart:
_declaration = _getDeclaration(this.runtimeType);
we'll need to find the declaration using the tag name (or "is" attribute), not the type name.