Multiple imports with noscript tags, only contents of one are displayed (tags are correct however) #14274

Closed
DartBot opened this Issue Oct 21, 2013 · 5 comments

Comments

Projects
None yet
3 participants
@DartBot

DartBot commented Oct 21, 2013

This issue was originally filed by @butlermatt


Fork this repo:
https://github.com/butlermatt/noscript_bug

Run noscript_bug.html and click on buttons. Content does not change, however notice console output does show correct tags.

Now remove the noscript attribute on one or more of the components (one_element, two_element and help_me). And uncomment the script lines. Run app again. Content is displayed as expected.

I have tried this with Polymer 0.8.4 and issue is the same (previous version was 0.8.2)

Also see discussion here:
https://groups.google.com/a/dartlang.org/d/topic/web-ui/15sZSS0LVYM/discussion

@DartBot

This comment has been minimized.

Show comment Hide comment
@DartBot

DartBot Oct 21, 2013

This comment was originally written by @butlermatt


Opps to reiterate the title...

Multiple custom elements with noscript attribute are imported. While the tags update correctly the contents of the tag are no changing. That is one_element.html content displays but when I load two-element custom element the tags update but the content is still the same as one-element. Similar when updating with help-me element. However if I add an empty class and remove the noscript attribute, the contents displayed by the tags updates accordingly.

DartBot commented Oct 21, 2013

This comment was originally written by @butlermatt


Opps to reiterate the title...

Multiple custom elements with noscript attribute are imported. While the tags update correctly the contents of the tag are no changing. That is one_element.html content displays but when I load two-element custom element the tags update but the content is still the same as one-element. Similar when updating with help-me element. However if I add an empty class and remove the noscript attribute, the contents displayed by the tags updates accordingly.

@jmesserly

This comment has been minimized.

Show comment Hide comment
@jmesserly

jmesserly Oct 21, 2013

Member

ah! thanks for the repro. I think I figured it out. Bug is here in instance.dart:

_declaration = _getDeclaration(this.runtimeType);

we'll need to find the declaration using the tag name (or "is" attribute), not the type name.


Added this to the M8 milestone.
Removed Priority-Unassigned label.
Added Priority-High, Library-Polymer, Area-Polymer, Triaged labels.

Member

jmesserly commented Oct 21, 2013

ah! thanks for the repro. I think I figured it out. Bug is here in instance.dart:

_declaration = _getDeclaration(this.runtimeType);

we'll need to find the declaration using the tag name (or "is" attribute), not the type name.


Added this to the M8 milestone.
Removed Priority-Unassigned label.
Added Priority-High, Library-Polymer, Area-Polymer, Triaged labels.

@sigmundch

This comment has been minimized.

Show comment Hide comment
@sigmundch

sigmundch Oct 23, 2013

Member

Added Started label.

Member

sigmundch commented Oct 23, 2013

Added Started label.

@jmesserly

This comment has been minimized.

Show comment Hide comment
@jmesserly

jmesserly Oct 24, 2013

Member

Set owner to @sigmundch.

Member

jmesserly commented Oct 24, 2013

Set owner to @sigmundch.

@sigmundch

This comment has been minimized.

Show comment Hide comment
@sigmundch

sigmundch Oct 24, 2013

Member

Fixed in r29186 - the fix should make it on the next release (>= 0.8.7)


Added Fixed label.

Member

sigmundch commented Oct 24, 2013

Fixed in r29186 - the fix should make it on the next release (>= 0.8.7)


Added Fixed label.

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment