Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support operator call #1604

Closed
DartBot opened this issue Feb 9, 2012 · 14 comments

Comments

Projects
None yet
7 participants
@DartBot
Copy link

commented Feb 9, 2012

This issue was originally filed by ms...@unipro.ru


Support operator call for custom classes since it is already described in the specification.

@anders-sandholm

This comment has been minimized.

Copy link
Contributor

commented Feb 9, 2012

Added Area-VM, Triaged labels.

@madsager

This comment has been minimized.

Copy link
Member

commented Mar 7, 2012

Issue #1986 has been merged into this issue.

@sethladd

This comment has been minimized.

Copy link
Member

commented May 7, 2012

Marked this as blocking #2931.

@iposva-google

This comment has been minimized.

Copy link
Contributor

commented Jun 1, 2012

Added this to the M1 milestone.

@anders-sandholm

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2012

Marked this as being blocked by #2931.

@iposva-google

This comment has been minimized.

Copy link
Contributor

commented Oct 10, 2012

Removed this from the M1 milestone.
Added this to the M2 milestone.
Marked this as blocking #2931.
Unmarked this as blocking #2931.
Marked this as being blocked by #2931.
Unmarked this as being blocked by #2931.

@DartBot

This comment has been minimized.

Copy link
Author

commented Oct 11, 2012

This comment was originally written by antonm@google.com


Issue #5797 has been merged into this issue.


cc @floitschG.

@dgrove

This comment has been minimized.

Copy link
Member

commented Oct 12, 2012

Issue #5835 has been merged into this issue.

@crelier

This comment has been minimized.

Copy link
Member

commented Dec 12, 2012

Set owner to @crelier.
Added Started label.
Unmarked this as being blocked by #2931.

@crelier

This comment has been minimized.

Copy link
Member

commented Dec 12, 2012

Fixed at r16009.


Added Fixed label.

@DartBot

This comment has been minimized.

Copy link
Author

commented Dec 24, 2012

This comment was originally written by alexe.kaigorodov@gmail.com


The co19 test 14_Types/5_Function_Types_A06_t01 still fails.

@crelier

This comment has been minimized.

Copy link
Member

commented Dec 27, 2012

Thanks for triaging this test. There are 3 issues with it:

line 21: the call method is missing a body, making it abstract. Failing the test is therefore correct, since there is actually no call method.

line 37: wrong expectation. new J() is f.

line 41: wrong expectation. new K() is f.

Thanks,
Regis

@DartBot

This comment has been minimized.

Copy link
Author

commented Dec 28, 2012

This comment was originally written by alexe.kaigorodov@gmail.com


After fixing, the test still fails:
out/Debug_ia32/dart --ignore-unrecognized-flags --enable-type-checks /home/kaigorodov/dash/dash/co19/tests/co19/src/Language/14_Types/5_Function_Types_A06_t01.dart
Unhandled exception:
Expect.isTrue(false) fails.
#­0 Expect._fail (bootstrap:655:5)
#­1 Expect.isTrue (bootstrap:494:10)
#­2 main (file:///home/kaigorodov/dash/dash/co19/tests/co19/src/Language/14_Types/5_Function_Types_A06_t01.dart:33:16)

typedef void f(p1, p2);
class I {
  void call(a1, a2){}
}
Expect.isTrue(new I() is f); // line 33

@ghost

This comment has been minimized.

Copy link

commented Dec 28, 2012

Should be fixed with r16541

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.