code_transformer pkg: unable to handle when dart exe is a symlink

[sethladd]

Consider this case:

/usr/local/bin/dart ==> /usr/local/Cellar/dart/1.5.3/bin/dart ==> /usr/local/Cellar/dart/1.5.3/libexec/bin/dart

This is what homebrew does.

The code in dartSdkDirectory assumed that which dart points to the physical location of dart.

[sethladd]

Looks like calling something like:

var file = new File(result.stdout.trim());
// check if file is a symlink
var realLocation = file.resolveSymbolicLinksSync();
    var sdkDir = path.dirname(path.dirname(reloadLocation));
    if (isSdkDir(sdkDir)) return sdkDir;

Or similar might do the trick?

[sethladd]

FWIW this affects the zengen package on pub, which uses code_transformers. At least, it affects: code_transformers + dart sdk installed by homebrew + mac.

[blois]

This code is a complete (and extremely unfortunate) hack around 16994.

Pub just recently added a pseudo-package '$sdk' which it sounds like we can use, though this will take a chunk of refactoring to change the resolver's use of dart sources from proxies of file-based sources to be asset-based sources. Though it may clean some stuff up by having everything be asset-based.

[sethladd]

Might also let it work cross-platform, too. Another benefit. :)

[sigmundch]

We added the workaround to resolve the symlink for now in code_transformers 0.2.3+2 (see
https://codereview.chromium.org//795433002)

---

Added Fixed label.

[sethladd]

Thanks very much!

[DartBot]

This issue has been moved to dart-archive/code_transformers#20.