Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support enums in Dart VM #21416

Closed
sethladd opened this issue Oct 24, 2014 · 12 comments
Closed

Support enums in Dart VM #21416

sethladd opened this issue Oct 24, 2014 · 12 comments

Comments

@sethladd
Copy link
Contributor

@sethladd sethladd commented Oct 24, 2014

Tracking bug.

Draft spec: https://www.dartlang.org/docs/spec/EnumsTC52draft.pdf

@iposva-google
Copy link
Contributor

@iposva-google iposva-google commented Oct 29, 2014

Set owner to @mhausner.
Added Accepted label.

@iposva-google
Copy link
Contributor

@iposva-google iposva-google commented Oct 29, 2014

cc @gbracha.

@pq
Copy link
Member

@pq pq commented Oct 29, 2014

Thinking ahead, will there be a flag (a la the one for async)? That is something like "--enable_enums"? I've got support in flight for Intellij/IDEA and want to be sure to set VM options appropriately.

@gbracha
Copy link
Contributor

@gbracha gbracha commented Oct 29, 2014

It won't need a flag. It's TC52 approved (TM).

@DartBot
Copy link

@DartBot DartBot commented Oct 29, 2014

This comment was originally written by @mhausner


Enums are part of the spec that we expect ECMA to bless shortly, so I don't think we will need a flag to enable or disable the feature.

@pq
Copy link
Member

@pq pq commented Oct 29, 2014

No muss, no fuss. That's the best answer possible. Thanks!

@kwalrath
Copy link
Member

@kwalrath kwalrath commented Nov 13, 2014

Marked this as blocking #88.

@sethladd
Copy link
Contributor Author

@sethladd sethladd commented Nov 17, 2014

Added Started label.

@DartBot
Copy link

@DartBot DartBot commented Nov 19, 2014

This comment was originally written by @mhausner


Enum is fully supported as of r41815.

No flag is necessary to use enums.


Added Fixed label.

@DartBot
Copy link

@DartBot DartBot commented Nov 19, 2014

This comment was originally written by @paulevans


I know it's a little late - but enums as specified do not cover interop situations well where there's an expectation that an enum can be associated with a particular value (e.g. pnacl, http status messages with gaps in ranges, Windows messages, etc).

I'm also concerned about a hidden runtime impact of using an enum over a defined constant value that programmers coming from a C/C++/C# background would assume is not there.

I have no idea if this is the best place to register my concerns, but that's my 2c anyway.

@iposva-google
Copy link
Contributor

@iposva-google iposva-google commented Nov 19, 2014

Regarding comment 11: This is not the correct spot to raise these issues. This bug is about implementing the current specification in the VM. If you want to raise your concerns please do so in a new bug.

@DartBot
Copy link

@DartBot DartBot commented Dec 28, 2014

This comment was originally written by softwaredevjirk...@gmail.com


I filled the first comment from @­11 as Issue #6

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
7 participants