Implement null-aware operators #23454

Closed
sethladd opened this Issue May 14, 2015 · 16 comments

Comments

Projects
None yet
8 participants
@sethladd
Member

sethladd commented May 14, 2015

The null-aware operators proposal has been accepted by the DEP committee and is in the Dart language spec. Implementation should be underway, and it doesn't need to be behind any sort of flag.

This is the main tracking issue. Individual issues are below:

Edited by @nex3 to match other similar issues

@sethladd

This comment has been minimized.

Show comment
Hide comment
@sethladd

sethladd May 14, 2015

Member

Marked this as being blocked by #23455.

Member

sethladd commented May 14, 2015

Marked this as being blocked by #23455.

@sethladd

This comment has been minimized.

Show comment
Hide comment
@sethladd

sethladd May 14, 2015

Member

Marked this as being blocked by #23456.

Member

sethladd commented May 14, 2015

Marked this as being blocked by #23456.

@sethladd

This comment has been minimized.

Show comment
Hide comment
@sethladd

sethladd May 14, 2015

Member

Marked this as being blocked by #23457.

Member

sethladd commented May 14, 2015

Marked this as being blocked by #23457.

@sethladd

This comment has been minimized.

Show comment
Hide comment
@sethladd

sethladd May 14, 2015

Member

See also https://youtrack.jetbrains.com/issue/WEB-16568 for the JetBrains issue.

Member

sethladd commented May 14, 2015

See also https://youtrack.jetbrains.com/issue/WEB-16568 for the JetBrains issue.

@stereotype441

This comment has been minimized.

Show comment
Hide comment
@stereotype441

stereotype441 May 20, 2015

Member

Note: many refinements were made after the DEP was written but prior to committing changes to the spec. For the definitive semantics, please see https://codereview.chromium.org//1031323002.

Member

stereotype441 commented May 20, 2015

Note: many refinements were made after the DEP was written but prior to committing changes to the spec. For the definitive semantics, please see https://codereview.chromium.org//1031323002.

@sethladd

This comment has been minimized.

Show comment
Hide comment
Member

sethladd commented Jun 19, 2015

@sethladd

This comment has been minimized.

Show comment
Hide comment
@sethladd

sethladd Jun 19, 2015

Member

As of now, looks like dart2js and VM have completed their implementations. Looks like analyzer is real close.

Member

sethladd commented Jun 19, 2015

As of now, looks like dart2js and VM have completed their implementations. Looks like analyzer is real close.

@stereotype441 stereotype441 added this to the 1.12 milestone Jun 19, 2015

@stereotype441

This comment has been minimized.

Show comment
Hide comment
@stereotype441

stereotype441 Jun 19, 2015

Member

Analyzer implementation is feature complete. There is one minor outstanding bug (#23464), but it shouldn't delay anything.

After discussion with Seth, it looks like all that needs to be done is to enable support by default in the VM, analyzer, and dart2js, and to drop the flag --enable-null-aware-operators from the tests. Our aim is to have this switched on by 1.12.

Member

stereotype441 commented Jun 19, 2015

Analyzer implementation is feature complete. There is one minor outstanding bug (#23464), but it shouldn't delay anything.

After discussion with Seth, it looks like all that needs to be done is to enable support by default in the VM, analyzer, and dart2js, and to drop the flag --enable-null-aware-operators from the tests. Our aim is to have this switched on by 1.12.

@floitschG floitschG added Area-Meta and removed Area-NONE labels Jun 24, 2015

@nex3

This comment has been minimized.

Show comment
Hide comment
@nex3

nex3 Jul 2, 2015

Member

@stereotype441 @sethladd are there issues filed to drop the flag?

Member

nex3 commented Jul 2, 2015

@stereotype441 @sethladd are there issues filed to drop the flag?

@stereotype441

This comment has been minimized.

Show comment
Hide comment
@stereotype441

stereotype441 Jul 6, 2015

Member

@nex3 As far as I'm aware there are no issues filed to drop the flag; in fact, I don't even know how the VM and Dart2js behave if the flag is absent. It's on my personal TODO list to drop the flag from the tests and modify analyzer to implement the proper behavior by default; once I've done that, if I see that it causes VM and/or Dart2js failures I'll file bugs against those platforms.

Member

stereotype441 commented Jul 6, 2015

@nex3 As far as I'm aware there are no issues filed to drop the flag; in fact, I don't even know how the VM and Dart2js behave if the flag is absent. It's on my personal TODO list to drop the flag from the tests and modify analyzer to implement the proper behavior by default; once I've done that, if I see that it causes VM and/or Dart2js failures I'll file bugs against those platforms.

@sigmundch

This comment has been minimized.

Show comment
Hide comment
@sigmundch

sigmundch Jul 6, 2015

Member

dart2js will show an error message requesting that you provide the flag. But it should be easy to remove it too. I just filed #23791 to track

Member

sigmundch commented Jul 6, 2015

dart2js will show an error message requesting that you provide the flag. But it should be easy to remove it too. I just filed #23791 to track

@nex3

This comment has been minimized.

Show comment
Hide comment
@nex3

nex3 Jul 6, 2015

Member

It looks like they're enabled by default in the latest VM. I've filed #23793 to track enabling them by default in the Analyzer so there's something to link to in the checklist above.

Member

nex3 commented Jul 6, 2015

It looks like they're enabled by default in the latest VM. I've filed #23793 to track enabling them by default in the Analyzer so there's something to link to in the checklist above.

@nex3 nex3 changed the title from Meta: Implement the null-aware operators to Implement null-aware operators Jul 6, 2015

@mit-mit

This comment has been minimized.

Show comment
Hide comment
@mit-mit

mit-mit Aug 17, 2015

Member

Meta bug, assigning to self to drive to completion for 1.12.

Member

mit-mit commented Aug 17, 2015

Meta bug, assigning to self to drive to completion for 1.12.

@mit-mit mit-mit self-assigned this Aug 17, 2015

@mit-mit

This comment has been minimized.

Show comment
Hide comment
@mit-mit

mit-mit Aug 18, 2015

Member

Marking #23794 complete, see comments there

Member

mit-mit commented Aug 18, 2015

Marking #23794 complete, see comments there

@mit-mit

This comment has been minimized.

Show comment
Hide comment
@mit-mit

mit-mit Aug 20, 2015

Member

Closing this: outside of the docs -- which don't ship in the sdk -- just the dart2js impl. of Class?m remains, and that can be shipped in 1.13.

Member

mit-mit commented Aug 20, 2015

Closing this: outside of the docs -- which don't ship in the sdk -- just the dart2js impl. of Class?m remains, and that can be shipped in 1.13.

@mit-mit mit-mit closed this Aug 20, 2015

@kwalrath

This comment has been minimized.

Show comment
Hide comment
Member

kwalrath commented Aug 20, 2015

@ykomatsu ykomatsu referenced this issue in rust-lang-ja/the-rust-programming-language-ja Feb 1, 2016

Closed

進行状況の整理 #44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment