Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dartdoc.bat has a wrong variable expansion and fails to run dartdoc #24252

Closed
dynaxis opened this issue Sep 1, 2015 · 6 comments
Closed

dartdoc.bat has a wrong variable expansion and fails to run dartdoc #24252

dynaxis opened this issue Sep 1, 2015 · 6 comments
Assignees
Labels
Milestone

Comments

@dynaxis
Copy link

@dynaxis dynaxis commented Sep 1, 2015

https://github.com/dart-lang/sdk/blob/1.12.0/sdk/bin/dartdoc.bat#L17

In the referenced line, $BIN_DIR should have been %BIN_DIR%. Due to this issue, dartdoc.bat won't run dartdoc properly.

@sethladd
Copy link
Contributor

@sethladd sethladd commented Sep 1, 2015

Sorry about that. Thanks for filing!

@keertip @whesse is there a way our Windows bots can run this and other .bat files during a build, to test they are correct?

cc @mit-mit

Loading

@keertip
Copy link
Contributor

@keertip keertip commented Sep 1, 2015

Thanks for the report!

Loading

@keertip
Copy link
Contributor

@keertip keertip commented Sep 1, 2015

Loading

@keertip keertip closed this Sep 1, 2015
@sethladd
Copy link
Contributor

@sethladd sethladd commented Sep 1, 2015

Can we roll this out in a 1.12.1 release? @keertip can we file a MergeToStable which I guess means MergeToPreviousReleaseBranch ?

Loading

@keertip
Copy link
Contributor

@keertip keertip commented Sep 1, 2015

Was just filing the issue! #24265

Loading

@sethladd
Copy link
Contributor

@sethladd sethladd commented Sep 1, 2015

Was just filing the issue!

You 🎸

Loading

@sethladd sethladd closed this Sep 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants