Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd --no-implicit-dynamic flag to strong mode #25573
Comments
This comment has been minimized.
This comment has been minimized.
Taking a look at this. |
This comment has been minimized.
This comment has been minimized.
Note this will include implicit dynamic in a type argument to a class/typedef/generic function/generic method. |
This comment has been minimized.
This comment has been minimized.
implemented in https://codereview.chromium.org/2093523002/. I sent to @leafpetersen to see if the design seems right. There's a lot more nuance than I'd thought at first. In particular, how to handle implicit generic types used as type annotations. But there are some other interesting cases too, like the return type of a function expression. |
This comment has been minimized.
This comment has been minimized.
So what we're brainstorming now is a set of flags as we gather data:
No current plans to implement these, but for completeness, here are some other ideas that have floated around:
|
This comment has been minimized.
This comment has been minimized.
CC @leafpetersen @munificent -- see above for my notes on the various flags we may want. |
forked from #24267, also see: dart-archive/dev_compiler#299, dart-archive/dev_compiler#363, dart-archive/dev_compiler#365