Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_HttpDetachedIncoming is missing test for no subscription #26379

Closed
floitschG opened this issue May 2, 2016 · 1 comment
Closed

_HttpDetachedIncoming is missing test for no subscription #26379

floitschG opened this issue May 2, 2016 · 1 comment
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-io P3 A lower priority bug or feature request triaged Issue has been triaged by sub team

Comments

@floitschG
Copy link
Contributor

The class _HttpDetachedIncoming seems to be missing a test case for the case when subscription is null.
@floitschG floitschG added area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-io labels May 2, 2016
@a-siva
Copy link
Contributor

a-siva commented Oct 13, 2023

https://dart-review.googlesource.com/c/sdk/+/330201

@a-siva a-siva added triaged Issue has been triaged by sub team P3 A lower priority bug or feature request labels Oct 13, 2023
@a-siva a-siva closed this as completed Oct 13, 2023
copybara-service bot pushed a commit that referenced this issue Oct 13, 2023
@a-siva
[IO/http] - Fix for #49930
24155ef 
Check for null 'bufferedData' even in the path when 'subscription' is
null. Should also fix #26379

TEST=ci

Change-Id: Iacc18c8a38e2c5b36c5234495d39cf20bfd8bac3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/330201
Reviewed-by: Brian Quinlan <bquinlan@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-io P3 A lower priority bug or feature request triaged Issue has been triaged by sub team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@floitschG @a-siva