Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable VM assertions in Fuchsia and Flutter debug modes #29458

Open
rmacnak-google opened this Issue Apr 25, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@rmacnak-google
Copy link
Member

rmacnak-google commented Apr 25, 2017

Currently the VM does not run in debug mode when Fuchsia (dart_content_handler) or Flutter are in debug mode, because the GN variable dart_debug is only set to true for the standalone VM. This flag includes a comment saying it was to avoid making embedders too slow in their debug modes. We have since made our debug builds faster by disable heap verification by default and using -O2 instead of -O1 (gyp had long since used -O2 for debug builds, but the change to GN is more recent). We should consider always putting the VM in debug mode when the embedder is in debug mode.

Currently on Fuchsia I'm seeing assertion failures in the loader, event handler and long jump scopes.

@johnmccutchan @zanderso @a-siva

rmacnak-google added a commit that referenced this issue Apr 26, 2017

Fix some assertion failures on Fuchsia
 - Fix longjmp asserts to work with -fsanitize=safe-stack.
 - Remove outdated asserts in gen_snapshot assuming generation of a core snapshot.
 - Move depfile resolution so it happens outside of the tag handler.

Issue #29458

R=asiva@google.com, johnmccutchan@google.com, zra@google.com

Review-Url: https://codereview.chromium.org/2837873005 .

dart-bot pushed a commit that referenced this issue Oct 16, 2018

[build] Debug means debug!
Bug: #29458
Change-Id: Ic7d4cb81c65da9c7a8970431b4e02f3d2d19e556
Reviewed-on: https://dart-review.googlesource.com/c/77980
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>

dart-bot pushed a commit that referenced this issue Oct 19, 2018

Revert "[build] Debug means debug!"
This reverts commit 984c407.

Reason for revert:
This change causes failures on the flutter engine tests.
Reverting for now to unblock the Dart roll.

#34872


Original change's description:
> [build] Debug means debug!
> 
> Bug: #29458
> Change-Id: Ic7d4cb81c65da9c7a8970431b4e02f3d2d19e556
> Reviewed-on: https://dart-review.googlesource.com/c/77980
> Reviewed-by: Siva Annamalai <asiva@google.com>
> Reviewed-by: Zach Anderson <zra@google.com>
> Commit-Queue: Ryan Macnak <rmacnak@google.com>

TBR=rmacnak@google.com,zra@google.com,asiva@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: #29458
Change-Id: I45ea9e1408d71e79d28d8ff0f5aea7649d5fb2ac
Reviewed-on: https://dart-review.googlesource.com/c/80920
Reviewed-by: Aart Bik <ajcbik@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.