Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Every object is `null` when using Dartium 50, WebStorm 2017.1.2 on Windows 10 #29854

Closed
mnordine opened this issue Jun 13, 2017 · 10 comments

Comments

@mnordine
Copy link
Contributor

commented Jun 13, 2017

I've seen this behavior on 2 machines. Rolling back Dartium works.

@zoechi

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2017

and 2017.1.4 on Mac

@terrylucas

This comment has been minimized.

Copy link
Member

commented Jun 15, 2017

@alexander-doroshko

Can you investigate on the WebStorm side on what you're not getting from Dartium? For most objects I'm seeing null, scalars (strings, ints, etc. are valid), many dart:html items like button, div seem to appear too. However, many others are null.

A good simple example to try is from the https://github.com/dart-lang/dart-tutorials-samples
use the anagram sample

Setting a BP on the generateNewLetters(); line in the function:

void newletters(Event e) {
letterpile.children.clear();
result.children.clear();
generateNewLetters();
}

will show both this and e as null?

@jwren

This comment has been minimized.

Copy link
Member

commented Jun 15, 2017

@terrylucas I know before the roll you tested it against IJ, which version and platform works?

Also, is the issue presenting itself in the Webstorm 2017.2 EAP or Ultimate 2017.2 EAP?

FYI: Alex is out on vacation next week.

@terrylucas

This comment has been minimized.

Copy link
Member

commented Jun 15, 2017

Tested to make sure BPs worked (and some variables do display values) however it looks like others do not. I also tried with 2017.2 EAP and it fails the same way. In particular, in the anagram example the instance for e displays as null.

@alexander-doroshko

This comment has been minimized.

Copy link

commented Jun 15, 2017

I'm OOO till June, 26. The first step is to see what Dartium sends to the IDE, maybe it is sending nulls instead of real var values. To get these logs click Help -> Find Action, type Registry, open it, search for js.debugger.wip.log property, set it to some log file path like /foo/bar/log.json. This file will be rewritten on each debug session.

@alexander-doroshko

This comment has been minimized.

Copy link

commented Jun 16, 2017

@terrylucas @jwren I compared debug logs and see some difference between Dartium 1.23 and 1.24.1 that I think leads to nulls as var values. I played with the anagram project and a single breakpoint in void newletters(Event e). Note that this is expected to be null, but e - not, it is expected to be MouseEvent. IDE sends "Runtime.getProperties" request and receives "handleResult" event. The difference is that the response from Dartium 1.24.1 includes "value":null for the e variable, but response from Dartium 1.23 doesn't contain "value" attribute at all. See attached screenshot. I'm not an expert in the protocol so can't say for sure whether it is a Dartium fault or IDE incorrectly interprets the response or both. I'll be able to ask colleagues after vacation unless you know the answer.
image

@jwren

This comment has been minimized.

Copy link
Member

commented Jun 16, 2017

@alexander-doroshko Thanks for looking into the issue. I am not familiar with the protocol requirements/ expectations either.

@terrylucas

This comment has been minimized.

Copy link
Member

commented Jun 16, 2017

@terrylucas

This comment has been minimized.

Copy link
Member

commented Jun 20, 2017

Have a fix for this CL

terrylucas added a commit that referenced this issue Jun 20, 2017
Update to latest WebKit changes:
- Fix DevConsole crash with JS see Issue #29873
     CL https://codereview.chromium.org/2941143002
- Fix debugging in WebStorm, NULL returned for JS objects see Issue #29854
     CL https://codereview.chromium.org/2945063002

TBR=jacobr@google.com

Review-Url: https://codereview.chromium.org/2952643002 .
whesse added a commit that referenced this issue Jun 22, 2017
Update to latest WebKit changes:
- Fix DevConsole crash with JS see Issue #29873
     CL https://codereview.chromium.org/2941143002
- Fix debugging in WebStorm, NULL returned for JS objects see Issue #29854
     CL https://codereview.chromium.org/2945063002

TBR=jacobr@google.com

Review-Url: https://codereview.chromium.org/2952643002 .
@terrylucas

This comment has been minimized.

Copy link
Member

commented Jun 26, 2017

Released in 1.24.2 stable

@terrylucas terrylucas closed this Jun 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.